PHP8 is_resource behavioral change affects AbstractMonitoringMiddleware

[mhsdef]

Describe the bug

AbstractMonitoringMiddleware::prepareSocket's is_resource check (#):

private function prepareSocket($forceNewConnection = false)
{
    if (!is_resource(self::$socket)
        || $forceNewConnection
        || socket_last_error(self::$socket)
    ) {
        self::$socket = socket_create(AF_INET, SOCK_DGRAM, SOL_UDP);
        socket_clear_error(self::$socket);
        socket_connect(self::$socket, $this->getHost(), $this->getPort());
    }

    return self::$socket;
} 

Looks affected by https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.resource2object

Expected Behavior

The check to cover both PHP7 and PHP8 behaviors.

Current Behavior

The check only covers <PHP8 behavior.

Reproduction Steps

See this:
https://onlinephp.io/c/3574d

Possible Solution

Check for !self::$socket instanceof Socket as well to cover PHP8.

Additional Information/Context

No response

SDK version used

master

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.0.23

[yenfryherrerafeliz]

Hi @hewsut, thanks for opening this issue. I agree with the suggested change. I will mark this issue to be reviewed so we can address it further.

Thanks!

[MattPearce]

@yenfryherrerafeliz this issue is blocking our PHP v8 upgrade, this PR will fix the issue if you could please merge it:

#2865

[yenfryherrerafeliz]

Hi @MattPearce, I have left a comment on the PR. Would you please be able to take look to it.

Thanks!

[yenfryherrerafeliz]

This issue has been fixed by the following PR. Closing for now.

Thanks!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.