Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_link unexpected behavior #268

Closed
AlexKovalevych opened this issue Apr 2, 2014 · 1 comment · Fixed by #276
Closed

is_link unexpected behavior #268

AlexKovalevych opened this issue Apr 2, 2014 · 1 comment · Fixed by #276

Comments

@AlexKovalevych
Copy link
Contributor

is_link('s3://correct_bucket/not_existing_file') throws a warning, in php it always return false
Possible solution could be to return array of zeroes according to php doc http://www.php.net/manual/en/streamwrapper.url-stat.php

Unknown or unavailable values should be set to a rational value (usually 0).

but that didn't work and broke filetype tests #267
Any ideas about how to make it work correctly for both functions?

mtdowling added a commit that referenced this issue Apr 14, 2014
PHP stream wrappers provide flags to url_stat that should be used to determine
the response of a call and whether or not it raises an error. I've updated the
Amazon S3 stream wrapper to utilize these combinations of flags to emulate the
error handling of the "http" protocol stream wrapper.

Closes #268
@mtdowling
Copy link
Member

I just pushed a fix for this that should address this issue and other related issues. This fix allows the Amazon S3 stream wrapper to better emulate the behavior of other stream wrappers with regards to when it raises errors or returns false. I'm also removing the "throw_exceptions" option from the stream wrapper as that completely breaks compatibility with other stream wrappers.

mtdowling added a commit that referenced this issue Oct 14, 2014
PHP stream wrappers provide flags to url_stat that should be used to determine
the response of a call and whether or not it raises an error. I've updated the
Amazon S3 stream wrapper to utilize these combinations of flags to emulate the
error handling of the "http" protocol stream wrapper.

Closes #268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants