Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpunit 74 patch #1918

Merged
merged 5 commits into from Dec 6, 2019
Merged

Phpunit 74 patch #1918

merged 5 commits into from Dec 6, 2019

Conversation

@howardlopez
Copy link
Contributor

howardlopez commented Dec 5, 2019

  • Adds a test bootstrap patch for a PHPUnit class file that triggers deprecation warnings for PHP 7.4+. This is necessary because the SDK supports older versions of PHP and currently relies on older, now unsupported, versions of PHPUnit.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #1918 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1918   +/-   ##
=========================================
  Coverage     93.32%   93.32%           
  Complexity     3493     3493           
=========================================
  Files           195      195           
  Lines          9286     9286           
=========================================
  Hits           8666     8666           
  Misses          620      620
Impacted Files Coverage Δ Complexity Δ
src/Sdk.php 90.62% <0%> (ø) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b858d...28c82b5. Read the comment docs.

@howardlopez howardlopez requested a review from srchase Dec 5, 2019
@srchase
srchase approved these changes Dec 5, 2019
@howardlopez howardlopez merged commit 897c14e into aws:master Dec 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.