Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle 7 is released, no beta test needed #2050

Merged
merged 1 commit into from Jul 1, 2020
Merged

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Jun 30, 2020

We test with Guzzle 5 on "prefer-lowest".
We test with Guzzle 6 on PHP < 7.2
We test with Guzzle 7 on PHP ≥ 7.2

@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 30, 2020

The CI failure is unrelated to this PR. It seams like they are related because of the release to Guzzle 7. I dont know the build sequence, but it seams like it is just CI that fails, but the library is working.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #2050 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2050   +/-   ##
=========================================
  Coverage     93.12%   93.12%           
  Complexity     3736     3736           
=========================================
  Files           206      206           
  Lines          9954     9954           
=========================================
  Hits           9270     9270           
  Misses          684      684           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6848e85...141f425. Read the comment docs.

Copy link
Contributor

@howardlopez howardlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nyholm! Yes, there were some failing CI elements with the release of Guzzle 7 that were addressed in another PR.

@howardlopez howardlopez merged commit 7049177 into aws:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants