bugfix: sts-credential-providers #3203
Merged
+1,467
−1,209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenfryherrerafeliz
requested changes
Oct 27, 2025
src/Credentials/AssumeRoleWithWebIdentityCredentialProvider.php
Outdated
Show resolved
Hide resolved
tests/Credentials/AssumeRoleWithWebIdentityCredentialProviderTest.php
Outdated
Show resolved
Hide resolved
|
Going a different direction with this. I'll let you know when it's updated |
stobrien89
force-pushed
the
bugfix-sts-providers
branch
from
3ce653f to
180280f
Compare
yenfryherrerafeliz
requested changes
Oct 27, 2025
src/Credentials/AssumeRoleWithWebIdentityCredentialProvider.php
Outdated
Show resolved
Hide resolved
tests/Credentials/AssumeRoleWithWebIdentityCredentialProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Credentials/AssumeRoleWithWebIdentityCredentialProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Credentials/AssumeRoleWithWebIdentityCredentialProviderTest.php
Outdated
Show resolved
Hide resolved
tests/Credentials/AssumeRoleWithWebIdentityCredentialProviderTest.php
Outdated
Show resolved
Hide resolved
stobrien89
force-pushed
the
bugfix-sts-providers
branch
from
180280f to
368f4cd
Compare
yenfryherrerafeliz
approved these changes
Oct 28, 2025
stobrien89
force-pushed
the
bugfix-sts-providers
branch
from
368f4cd to
cc4cb1d
Compare
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #3197
Description of changes:
Adds support for resolving the region for STS clients created by assume role providers. By default, the credentials chain will pass client configuration to expose the top-level client's region. When providers are called outside the context of a client, they will accept
regionin-code configuration,regionsource profile configuration (for roles assumed via profiles), and will attempt to resolveAWS_REGIONif any of the aforementioned options don't produce a region.This also adds a notice that prompts to configure a region if a region cannot be found. These providers will still fall back to
us-east-1, but this is likely to change in the future.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.