Added time_attr and time marshaler #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awood45
suggested changes
Jun 7, 2018
| it 'converts Dates to Time' do | ||
| expected = Time.parse("2009-02-13 08:00:00 UTC") | ||
| input = Date.parse("2009-02-13") | ||
| expect(@marshaler.type_cast(input)).to eq(expected) |
There was a problem hiding this comment.
This test will only work if the computer running it is in the Pacific Daylight Timezone or equivalent. Needs to be a system time zone agnostic test.
|
As discussed in Chime, I've removed the Date -> Time test as it's a pretty silly thing to do anyway. Anyone trying to save a Date as a Time attribute is just asking for it, and when they retrieve that record they can expect it to be a Time object anyway. |
awood45
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
RuboCop guidance says to avoid DateTime: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/DateTime
rubocop/rubocop#1952
And additionally, the Ruby docs recommend to use Time:
https://ruby-doc.org/stdlib-2.5.1/libdoc/time/rdoc/Time.html
With DateTime, we're able to save a Time object to DynamoDB but it comes back out as a DateTime. I added a time marshaler and defined a time_attr so that we can store serialized Time objects.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.