Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to bump up dependency version of aws-sdk-core in aws-sdk-ssm gem #2327

Closed
3 tasks done
sternik opened this issue Jun 11, 2020 · 14 comments
Closed
3 tasks done

Suggestion to bump up dependency version of aws-sdk-core in aws-sdk-ssm gem #2327

sternik opened this issue Jun 11, 2020 · 14 comments
Labels
bug This issue is a bug. pr/work-in-progress This PR is a draft and needs further work.

Comments

@sternik
Copy link
Contributor

sternik commented Jun 11, 2020

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug

The new version of aws-sdk-ssm should have aws-sdk-core dependency increase to at least 3.99.0 on RubyGems because you added a new plugin (http_checksum) to CORE.

Gem name

aws-sdk-ssm 1.81.0
aws-sdk-core 3.97.0

To Reproduce (observed behavior)

  • install aws-sdk-core in the old version (<3.99.0)
  • install aws-sdk-ssm
  • after importing aws-sdk-ssm error occurs:
`require': cannot load such file -- aws-sdk-core/plugins/http_checksum.rb (LoadError)

Expected behavior

aws-sdk-ssm should have aws-sdk-core dependency >= 3.99.0
@sternik sternik added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 11, 2020
@anvox
Copy link

anvox commented Jun 11, 2020

I found aws-sdk-kms version 1.34.0 has the same issue. Must upgrade core manually.

        1: from /Users/anvo/.rvm/gems/ruby-2.5.3@tp_common/gems/aws-sdk-kms-1.34.0/lib/aws-sdk-kms/client.rb:27:in `require'
LoadError (cannot load such file -- aws-sdk-core/plugins/http_checksum.rb)

@doublecompile doublecompile mentioned this issue Jun 11, 2020
Closed
@doublecompile
Copy link

The same issue applies to the aws-sdk-cloudwatchlogs gem (I'm running 1.32.0), and I'm sure other gems as well.

@sternik
Copy link
Contributor Author

sternik commented Jun 11, 2020 •
edited

Added PR #2329

@alextwoods alextwoods added pr/work-in-progress This PR is a draft and needs further work. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 11, 2020
@sufyanadam
Copy link

Same issue with aws-sdk-secretsmanager gem.

@mullermp
Copy link
Contributor

We will yank gems. We have updated the minimum core version. We are very sorry about this.

@mullermp
Copy link
Contributor

Currently getting throttled by rubygems, unfortunately we have to yank 223 gems..

@sufyanadam
Copy link

That is unfortunate. I suspect some people are blocked on deployments if they rely on things like aws-sdk-secretsmanager

@mullermp
Copy link
Contributor

Merged minimum core change + changelog entries for all gems - #2329

New release will start at 11 am. Yanking gems is a slow process. I tried automating it and got throttled.

kevindew added a commit to alphagov/email-alert-api that referenced this issue Jun 11, 2020
@kevindew
Remove aws-sdk-kms-1.34 dependency
bfed1e7 
This gem has been yanked. See
aws/aws-sdk-ruby#2327 and
aws/aws-sdk-ruby#2329
@kevindew kevindew mentioned this issue Jun 11, 2020
Merged
@mullermp mullermp mentioned this issue Jun 11, 2020
Closed
@alextwoods
Copy link
Contributor

There are ~30 remaining gems to yank (in progress). ETA for both removal of old gems and publishing of new gems is around 12pm PT.

@yshmarov
Copy link

looking forward

@japhillips87
Copy link

I just got the error Could not find aws-sdk-kms-1.34.0 in any of the sources when doing a ruby upgrade on an app. I got the message trying to run bundle. It was already pinned in my lockfile. I removed Gemfile.lock, ran gem install aws-skd-core (thanks @anvox) and the bundle succeeded. Just wanted to post here in case someone else runs into this issue.

@mullermp
Copy link
Contributor

All offending service gems have been yanked. They are currently being republished with a new minor version. A new aws-sdk-core version has also been published.

Very sorry about this. Our automation verifies against the latest set of gems. We will correct this to include edge cases with older core gems.

@yshmarov
Copy link

Fantastic! I see the update 1.34.1 is rolled out and it is working for me. You guys are great!
image

@mullermp
Copy link
Contributor

All new gems have been published.

@jlgoolsbee jlgoolsbee mentioned this issue Jun 11, 2020
Merged
@alextwoods alextwoods mentioned this issue Jun 12, 2020
Closed
@mortenholmgaard mortenholmgaard mentioned this issue Jun 12, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@sternik @japhillips87 @sufyanadam @anvox @doublecompile @yshmarov @mullermp @alextwoods