Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aws.empty_connection_pools! API #1451

Merged
merged 4 commits into from Apr 6, 2017
Merged

Add Aws.empty_connection_pools! API #1451

merged 4 commits into from Apr 6, 2017

Conversation

@iamatypeofwalrus
Copy link
Contributor

iamatypeofwalrus commented Mar 11, 2017

This pull request is in response to #1438 and adds an empty connection pool API to the top level Aws name space.

@iamatypeofwalrus

This comment has been minimized.

Copy link
Contributor Author

iamatypeofwalrus commented Mar 11, 2017

I wasn't quite sure how to test the pool without being too prescriptive of the underlying implementation. The spec file for ConnectionPool didn't have any tests for guidance :-(

@iamatypeofwalrus

This comment has been minimized.

Copy link
Contributor Author

iamatypeofwalrus commented Mar 11, 2017

Specs passed locally but not on CI. Taking a look.

Copy link
Member

awood45 left a comment

Update this commend and I think we're good to go.

# Applications that rely heavily on the `fork()` system call on POSIX systems
# should call this method in the child process directly after fork to ensure
# there are no race conditions between the parent process and its children
# for the pooled TCP connections.

This comment has been minimized.

Copy link
@awood45

awood45 Mar 13, 2017

Member

Should expand this to note that the method should return before making client calls in the child process. In theory, a threaded system might call this, start API calls before we clear, and have issues.

This comment has been minimized.

Copy link
@iamatypeofwalrus

iamatypeofwalrus Mar 19, 2017

Author Contributor

Updated documentation in latest commit

@awood45
awood45 approved these changes Apr 6, 2017
@awood45 awood45 merged commit f6600f8 into aws:master Apr 6, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
awood45 added a commit that referenced this pull request Jun 29, 2017
…ools-api

Add Aws.empty_connection_pools! API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.