Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aws.empty_connection_pools! API #1451

Merged
merged 4 commits into from
Apr 6, 2017
Merged

Add Aws.empty_connection_pools! API #1451

merged 4 commits into from
Apr 6, 2017

Conversation

iamatypeofwalrus
Copy link
Contributor

This pull request is in response to #1438 and adds an empty connection pool API to the top level Aws name space.

@iamatypeofwalrus
Copy link
Contributor Author

I wasn't quite sure how to test the pool without being too prescriptive of the underlying implementation. The spec file for ConnectionPool didn't have any tests for guidance :-(

@iamatypeofwalrus
Copy link
Contributor Author

Specs passed locally but not on CI. Taking a look.

Copy link
Member

@awood45 awood45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this commend and I think we're good to go.

# Applications that rely heavily on the `fork()` system call on POSIX systems
# should call this method in the child process directly after fork to ensure
# there are no race conditions between the parent process and its children
# for the pooled TCP connections.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should expand this to note that the method should return before making client calls in the child process. In theory, a threaded system might call this, start API calls before we clear, and have issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated documentation in latest commit

@awood45 awood45 merged commit f6600f8 into aws:master Apr 6, 2017
awood45 added a commit that referenced this pull request Jun 29, 2017
…ools-api

Add Aws.empty_connection_pools! API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants