Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced BigDecimal.new() with BigDecimal() #1937

Merged
merged 1 commit into from Dec 15, 2018
Merged

Replaced BigDecimal.new() with BigDecimal() #1937

merged 1 commit into from Dec 15, 2018

Conversation

totem3
Copy link
Contributor

@totem3 totem3 commented Dec 8, 2018 •
edited

fixes #1936

Use Kernel.BigDecimal method instead of BigDecimal.new

@awood45 awood45 self-assigned this Dec 14, 2018
@awood45
Copy link
Member

awood45 commented Dec 14, 2018

Changes look good in general. I'm currently verifying that the current setup is indeed broken in Ruby 2.6, and that this PR fixes the problem.

@awood45
Copy link
Member

awood45 commented Dec 14, 2018

Confirmed on both counts. Before we merge though, need to do a bit of administrivia. Can you confirm:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@totem3
Copy link
Contributor Author

totem3 commented Dec 15, 2018

Thank you for the review.

Yes, I confirmed and agreed to the lisence.

@awood45 awood45 merged commit dd61ef6 into aws:master Dec 15, 2018
@totem3 totem3 deleted the fix-bigdecimal branch December 19, 2018 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awood45 awood45 awood45 approved these changes

Assignees

@awood45 awood45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aws::DynamoDB::AttributeValue::Unmarshaler#format failed when type is s or ns in Ruby 2.6
2 participants
@totem3 @awood45