Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure locking around `@entries`. Fixes #2142. #2149

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@ioquatix
Copy link
Contributor

ioquatix commented Oct 30, 2019

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/master/CONTRIBUTING.md

Thank you for your contribution!

@mullermp mullermp merged commit 3472450 into aws:master Oct 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mullermp

This comment has been minimized.

Copy link
Contributor

mullermp commented Oct 30, 2019

Thanks for the contribution!

@ioquatix

This comment has been minimized.

Copy link
Contributor Author

ioquatix commented Oct 30, 2019

I am happy to provide feedback on other thread related issues but perhaps AWS can consider sponsoring my open source work so I can dedicate more time to it. Let me know if this is something worth exploring.

@mullermp

This comment has been minimized.

Copy link
Contributor

mullermp commented Oct 30, 2019

I may take you up on that if we ever run into any thread safe issues, and thanks for bringing this to our attention.

Regarding sponsorships, I've never looked into it, I'll ask around internally.

@ioquatix

This comment has been minimized.

Copy link
Contributor Author

ioquatix commented Oct 30, 2019

During my review I found other potentially unsafe code. Sponsorship or consulting are two options available if you want more of my time. Thanks for investigating it internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.