Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Object#url_for should inherit s3_port, use_ssl, and s3_force_path_style from the global configuration. #77

Merged
merged 1 commit into from Oct 17, 2012

Conversation

jamis
Copy link

@jamis jamis commented Oct 15, 2012

Currently, if you have "config.use_ssl" set to false, and "config.s3_force_path_style" set to true, when you go to generate a url with object#url_for, those settings are ignored. This patch makes it so that url_for honors the global configuration (but allows them to be overridden if necessary).

@trevorrowe
Copy link
Member

Looks good. Thank you for the bug fix/submission!

trevorrowe added a commit that referenced this pull request Oct 17, 2012
S3Object#url_for should inherit s3_port, use_ssl, and s3_force_path_style from the global configuration.
@trevorrowe trevorrowe merged commit d97e6bb into aws:master Oct 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants