Skip to content

Conversation

@hunterwerlla
Copy link
Contributor

@hunterwerlla hunterwerlla commented May 9, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code cleanup

Description

Related Issue(s), If Filed

#114

Checklist

  • I have read the README document
  • Local run of npm run package succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG (CHANGELOG.md)

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws aws deleted a comment from codecov-io May 9, 2019
@aws aws deleted a comment from codecov-io May 9, 2019
@hunterwerlla hunterwerlla marked this pull request as ready for review May 9, 2019 21:59
@hunterwerlla hunterwerlla requested a review from a team as a code owner May 9, 2019 21:59
@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #177 into master will increase coverage by 2.95%.
The diff coverage is 38.07%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #177      +/-   ##
========================================
+ Coverage    4.35%   7.3%   +2.95%     
========================================
  Files          67     69       +2     
  Lines        2366   2463      +97     
  Branches      273    293      +20     
========================================
+ Hits          103    180      +77     
- Misses       2263   2283      +20
Impacted Files Coverage Δ
Tasks/Common/sdkutils/awsTaskParametersBase.ts 0% <0%> (-7.5%) ⬇️
Tasks/Common/sdkutils.ts 0% <0%> (ø)
Tasks/S3Upload/S3Upload.ts 0% <0%> (ø) ⬆️
Tasks/Common/defaultClients.ts 0% <0%> (ø)
Tasks/S3Download/S3Download.ts 0% <0%> (ø) ⬆️
Tasks/Common/s3.ts 100% <100%> (ø)
Tasks/S3Download/DownloadTaskOperations.ts 82.5% <100%> (-2.69%) ⬇️
Tasks/S3Download/DownloadTaskParameters.ts 54.54% <100%> (ø) ⬆️
Tasks/Common/awsConnectionParameters.ts 13.76% <13.76%> (ø)
Tasks/Common/sdkutils/sdkutils.ts 23.17% <25%> (+0.94%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d867a3...ffc8df8. Read the comment docs.

@hunterwerlla hunterwerlla changed the base branch from werlla/getTsLintGoing to master May 14, 2019 17:04
@hunterwerlla hunterwerlla requested a review from awschristou May 14, 2019 19:07
@hunterwerlla hunterwerlla merged commit db8183d into master May 14, 2019
@hunterwerlla hunterwerlla deleted the werlla/s3upload branch May 14, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants