diff --git a/.golangci.yaml b/.golangci.yaml index 49889944..b94492a6 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -9,7 +9,6 @@ linters: - dupl - errcheck - gochecknoinits - - goconst - gocritic - gocyclo - gofmt diff --git a/go.mod b/go.mod index 4b0e5ce8..eb9a2aca 100644 --- a/go.mod +++ b/go.mod @@ -3,11 +3,9 @@ module github.com/aws/aws-xray-sdk-go require ( github.com/DATA-DOG/go-sqlmock v1.2.0 github.com/aws/aws-sdk-go v1.17.12 - github.com/davecgh/go-spew v0.0.0-20160907170601-6d212800a42e - github.com/jmespath/go-jmespath v0.0.0-20180206201540-c2b33e8439af + github.com/davecgh/go-spew v0.0.0-20160907170601-6d212800a42e // indirect github.com/pkg/errors v0.8.1 - github.com/pmezard/go-difflib v0.0.0-20151028094244-d8ed2627bdf0 + github.com/pmezard/go-difflib v0.0.0-20151028094244-d8ed2627bdf0 // indirect github.com/stretchr/testify v1.1.4 - golang.org/x/net v0.0.0-20190301231341-16b79f2e4e95 - golang.org/x/text v0.0.0-20190306152657-5d731a35f486 + golang.org/x/net v0.0.0-20190311183353-d8887717615a ) diff --git a/go.sum b/go.sum index 0be3bef1..b23bbb6b 100644 --- a/go.sum +++ b/go.sum @@ -12,8 +12,9 @@ github.com/pmezard/go-difflib v0.0.0-20151028094244-d8ed2627bdf0 h1:GD+A8+e+wFkq github.com/pmezard/go-difflib v0.0.0-20151028094244-d8ed2627bdf0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/stretchr/testify v1.1.4 h1:ToftOQTytwshuOSj6bDSolVUa3GINfJP/fg3OkkOzQQ= github.com/stretchr/testify v1.1.4/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs= -golang.org/x/net v0.0.0-20190301231341-16b79f2e4e95 h1:fY7Dsw114eJN4boqzVSbpVHO6rTdhq6/GnXeu+PKnzU= -golang.org/x/net v0.0.0-20190301231341-16b79f2e4e95/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= -golang.org/x/text v0.0.0-20190306152657-5d731a35f486 h1:XzEEnDs8NtiSU8gJvzuDjv+Kam+0nPN9pjOA3oZlxIY= -golang.org/x/text v0.0.0-20190306152657-5d731a35f486/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk= -golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= \ No newline at end of file +golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= +golang.org/x/net v0.0.0-20190311183353-d8887717615a h1:oWX7TPOiFAMXLq8o0ikBYfCJVlRHBcsciT5bXOrH628= +golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= +golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= +golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg= +golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= diff --git a/internal/logger/logger.go b/internal/logger/logger.go index b3c99a90..6ab83266 100644 --- a/internal/logger/logger.go +++ b/internal/logger/logger.go @@ -15,7 +15,7 @@ import ( "github.com/aws/aws-xray-sdk-go/xraylog" ) -// This internal pacakge hides the actual logging functions from the user. +// This internal package hides the actual logging functions from the user. // The Logger instance used by xray to log. Set via xray.SetLogger(). var Logger xraylog.Logger = xraylog.NewDefaultLogger(os.Stdout, xraylog.LogLevelInfo) diff --git a/resources/bindata.go b/resources/bindata.go index 22d05656..907704da 100644 --- a/resources/bindata.go +++ b/resources/bindata.go @@ -182,7 +182,7 @@ func AssetNames() []string { // _bindata is a table, holding each asset generator, mapped to its name. var _bindata = map[string]func() (*asset, error){ - "resources/AWSWhitelist.json": resourcesAwswhitelistJson, + "resources/AWSWhitelist.json": resourcesAwswhitelistJson, "resources/DefaultSamplingRules.json": resourcesDefaultsamplingrulesJson, "resources/ExampleSamplingRules.json": resourcesExamplesamplingrulesJson, } @@ -226,9 +226,10 @@ type bintree struct { Func func() (*asset, error) Children map[string]*bintree } + var _bintree = &bintree{nil, map[string]*bintree{ "resources": &bintree{nil, map[string]*bintree{ - "AWSWhitelist.json": &bintree{resourcesAwswhitelistJson, map[string]*bintree{}}, + "AWSWhitelist.json": &bintree{resourcesAwswhitelistJson, map[string]*bintree{}}, "DefaultSamplingRules.json": &bintree{resourcesDefaultsamplingrulesJson, map[string]*bintree{}}, "ExampleSamplingRules.json": &bintree{resourcesExamplesamplingrulesJson, map[string]*bintree{}}, }}, @@ -280,4 +281,3 @@ func _filePath(dir, name string) string { cannonicalName := strings.Replace(name, "\\", "/", -1) return filepath.Join(append([]string{dir}, strings.Split(cannonicalName, "/")...)...) } - diff --git a/strategy/sampling/centralized_test.go b/strategy/sampling/centralized_test.go index 6639b534..277735ab 100644 --- a/strategy/sampling/centralized_test.go +++ b/strategy/sampling/centralized_test.go @@ -966,7 +966,7 @@ func TestRefreshManifestRuleAddition(t *testing.T) { assert.Equal(t, r2, ss.manifest.Rules[1]) assert.Equal(t, r3, ss.manifest.Rules[2]) - // Assert on size of manfiest + // Assert on size of manifest assert.Equal(t, 3, len(ss.manifest.Rules)) assert.Equal(t, 3, len(ss.manifest.Index)) diff --git a/xray/aws.go b/xray/aws.go index 28748001..5be4cd89 100644 --- a/xray/aws.go +++ b/xray/aws.go @@ -87,19 +87,6 @@ var xRayBeforeSignHandler = request.NamedHandler{ }, } -var xRayAfterSignHandler = request.NamedHandler{ - Name: "XRayAfterSignHandler", - Fn: func(r *request.Request) { - endSubsegment(r) - }, -} - -var xRayBeforeSendHandler = request.NamedHandler{ - Name: "XRayBeforeSendHandler", - Fn: func(r *request.Request) { - }, -} - var xRayAfterSendHandler = request.NamedHandler{ Name: "XRayAfterSendHandler", Fn: func(r *request.Request) { @@ -287,8 +274,7 @@ func (j *jsonMap) data() interface{} { } func (j *jsonMap) search(keys ...string) *jsonMap { - var object interface{} - object = j.data() + object := j.data() for target := 0; target < len(keys); target++ { if mmap, ok := object.(map[string]interface{}); ok { diff --git a/xray/config_test.go b/xray/config_test.go index 0376dde1..a2c2ef7d 100644 --- a/xray/config_test.go +++ b/xray/config_test.go @@ -72,7 +72,7 @@ func (te *TestEmitter) Emit(seg *Segment) {} func (te *TestEmitter) RefreshEmitterWithAddress(raddr *net.UDPAddr) {} func (cms *TestContextMissingStrategy) ContextMissing(v interface{}) { - fmt.Sprintf("Test ContextMissing Strategy %v", v) + fmt.Printf("Test ContextMissing Strategy %v\n", v) } func stashEnv() []string { diff --git a/xray/default_emitter_test.go b/xray/default_emitter_test.go index 1f238c64..a6ca71a6 100644 --- a/xray/default_emitter_test.go +++ b/xray/default_emitter_test.go @@ -11,10 +11,11 @@ package xray import ( "encoding/json" "fmt" - "github.com/stretchr/testify/assert" "math/rand" "testing" "time" + + "github.com/stretchr/testify/assert" ) func TestNoNeedStreamingStrategy(t *testing.T) { diff --git a/xray/default_streaming_strategy_test.go b/xray/default_streaming_strategy_test.go index 88a9c138..dadd5d05 100644 --- a/xray/default_streaming_strategy_test.go +++ b/xray/default_streaming_strategy_test.go @@ -9,8 +9,9 @@ package xray import ( - "github.com/stretchr/testify/assert" "testing" + + "github.com/stretchr/testify/assert" ) func TestDefaultStreamingStrategyMaxSegmentSize(t *testing.T) { diff --git a/xray/lambda_test.go b/xray/lambda_test.go index 5e1e5bd7..5afc84c6 100644 --- a/xray/lambda_test.go +++ b/xray/lambda_test.go @@ -2,8 +2,9 @@ package xray import ( "context" - "github.com/stretchr/testify/assert" "testing" + + "github.com/stretchr/testify/assert" ) func TestLambdaSegmentEmit(t *testing.T) { diff --git a/xray/segment.go b/xray/segment.go index 0f358e65..75912236 100644 --- a/xray/segment.go +++ b/xray/segment.go @@ -162,7 +162,7 @@ func BeginSubsegment(ctx context.Context, name string) (context.Context, *Segmen name = name[:200] } - parent := &Segment{} + var parent *Segment // first time to create facade segment if getTraceHeaderFromContext(ctx) != nil && GetSegment(ctx) == nil { _, parent = newFacadeSegment(ctx) @@ -445,10 +445,8 @@ func (seg *Segment) AddError(err error) error { return nil } -func (seg *Segment) addError(err error) error { +func (seg *Segment) addError(err error) { seg.Fault = true seg.GetCause().WorkingDirectory, _ = os.Getwd() seg.GetCause().Exceptions = append(seg.GetCause().Exceptions, seg.ParentSegment.GetConfiguration().ExceptionFormattingStrategy.ExceptionFromError(err)) - - return nil } diff --git a/xray/segment_test.go b/xray/segment_test.go index 760407c9..dc19b301 100644 --- a/xray/segment_test.go +++ b/xray/segment_test.go @@ -39,7 +39,7 @@ func TestSubsegmentDataRace(t *testing.T) { go func() { defer wg.Done() ctx, seg := BeginSubsegment(ctx, "TestSubsegment1") - ctx, seg2 := BeginSubsegment(ctx, "TestSubsegment2") + _, seg2 := BeginSubsegment(ctx, "TestSubsegment2") seg2.Close(nil) seg.Close(nil) }() diff --git a/xray/sql.go b/xray/sql.go index 5d2e1111..83f8e396 100644 --- a/xray/sql.go +++ b/xray/sql.go @@ -295,4 +295,4 @@ func processNilSegment(ctx context.Context) { } else { globalCfg.ContextMissingStrategy().ContextMissing(failedMessage) } -} \ No newline at end of file +} diff --git a/xray/util_test.go b/xray/util_test.go index 61ea8b79..e85a2ecf 100644 --- a/xray/util_test.go +++ b/xray/util_test.go @@ -11,10 +11,11 @@ package xray import ( "context" "encoding/json" - "github.com/aws/aws-xray-sdk-go/header" "net" "net/http" "time" + + "github.com/aws/aws-xray-sdk-go/header" ) var ( diff --git a/xraylog/xray_log.go b/xraylog/xray_log.go index a790a109..4d9c439d 100644 --- a/xraylog/xray_log.go +++ b/xraylog/xray_log.go @@ -61,7 +61,7 @@ func NewDefaultLogger(w io.Writer, minLogLevel LogLevel) Logger { } type defaultLogger struct { - mu sync.Mutex + mu sync.Mutex w io.Writer minLevel LogLevel }