Updates changelog and benchmark for 2.7.0 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Aug 27, 2020
Contributor
anuraaga
left a comment
anuraaga
left a comment
There was a problem hiding this comment.
Thanks! I want to move this report into text files attached to the GitHub releases at some point to avoid an ever growing README.md. Let me know if you have any thoughts on that.
Contributor
Author
|
Could not agree more, we did some work on automating running & recording benchmarks that didn't get finished, but we probably would've settled on an approach like that if we had finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I'll just leave this here for the pending minor version release.
Note that the benchmark measurements are only recorded for the two modes decided in #198 and no longer reflect non-lifecycle Recorder benchmarks, and we've added the trace header & some ID creation benchmarks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.