Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EKS] [request]: Add ability to set oidc options #166

Open
jaxxstorm opened this issue Feb 15, 2019 · 26 comments

Comments

@jaxxstorm
Copy link

commented Feb 15, 2019

Tell us about your request
Using IAM for authentication is not always the most desirable solution. I'd like to be able to specify server side configuration, specifically for oidc authentication

Which service(s) is this request for?
EKS

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
When interacting with EKS clusters from non Amazon resources, having to create and specify access keys and secret keys can be cumbersome. We do this a lot at $work and because we can't specify an oidc configuration for the API server, we end up having to build our own clusters.
Being able to set the following API flags on the api server:

  • oidc-issuer-url
  • oidc-client-id
  • oidc-ca-file
  • oidc-username-claim
  • oidc-groups-claim

Would make this possible.

Are you currently working around this issue?
We are building our clusters using kubeadm :(

Additional context
This could be argued that it should be made possible to specify any API server flags, but I'd like to keep the scope smaller now

@jaxxstorm jaxxstorm added the Proposed label Feb 15, 2019

@abby-fuller abby-fuller added the EKS label Feb 15, 2019

@christopherhein

This comment has been minimized.

Copy link

commented Feb 15, 2019

Thanks for submitting this. This is not currently on our roadmap.

Can you help me understand more about you use case, would https://aws.amazon.com/blogs/opensource/integrating-ldap-ad-users-kubernetes-rbac-aws-iam-authenticator-project/ help to solve this?

It would give you the ability to use your AWS SSO to back your IAM roles which you could configure to use any LDAP/AD/SAML authentication mechanisms.

@jaxxstorm

This comment has been minimized.

Copy link
Author

commented Feb 16, 2019

This is possible yes, but when using tooling like Azure Active Directory, it add an additional layer of configuration.

Currently, as a user using oidc, I can:

  • Assign the user to a group in Azure AD
  • Map that group to a Kubernetes RBAC role

However, under the model you're proposing, I'd have to:

  • Assign a user to a group in Azure AD
  • Map that user to an IAM role, presumably with role assumption
  • Map the IAM role to a Kubernetes RBAC role

This additional layer adds complexity for debugging purposes. For example - if a user has a permission issue, I have to track the issue down by checking their AD group, then checking their IAM role, then RBAC. It seems unnecessary to me to not just add the API server flag.

@lstoll

This comment has been minimized.

Copy link

commented Feb 19, 2019

FWIW we ended up deploying an auth proxy to our clusters that authenticates users via OIDC, and then impersonates them to the API server. That allows us to manage access via our existing systems for users that may not have AWS access otherwise. The code is vaguely based on https://github.com/ericchiang/kube-oidc#kube-oidc-proxy

@christopherhein

This comment has been minimized.

Copy link

commented Feb 19, 2019

FWIW we ended up deploying an auth proxy to our clusters that authenticates users via OIDC, and then impersonates them to the API server. That allows us to manage access via our existing systems for users that may not have AWS access otherwise. The code is vaguely based on https://github.com/ericchiang/kube-oidc#kube-oidc-proxy

Sounds neat, is the code open source anywhere?

@jaxxstorm

This comment has been minimized.

Copy link
Author

commented Feb 19, 2019

@lstoll that sounds ideal - I would love some help/pointers. I really do think this should be reconsidered by AWS, so upvotes would be awesome if people want this feature

@sermilrod

This comment has been minimized.

Copy link

commented Feb 22, 2019

I am also interested in this feature. The ability to configure identity providers is something I would like EKS to support. I need this because we want to map specific users to rbac rules so we have full and granular control over who has what access to kubernetes clusters without having to create an IAM user nor assume a role for it. This is particularly important in multi-tenant clusters.

@universam1

This comment has been minimized.

Copy link

commented Mar 5, 2019

FWIW we ended up deploying an auth proxy to our clusters that authenticates users via OIDC, and then impersonates them to the API server. That allows us to manage access via our existing systems for users that may not have AWS access otherwise.

We do the similar as well, but the OIDC integration in K8s is required still in order to map the JWT token into RBAC roles. For instance Kubernetes Dashboard needs that mapping to gain cluster level access.
@christopherhein this missing support is a surprise no-go for us in the effort moving to EKS!

@christopherhein

This comment has been minimized.

Copy link

commented Mar 5, 2019

Thank you everyone for the feedback, really appreciate you talking about your use cases. Changing the label to under consideration 👍

@jaxxstorm

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

@christopherhein would it be easier to get this considered if we filed an issue which allows us to specify API server configuration in general, rather than specifically for oidc flags?

@christopherhein

This comment has been minimized.

Copy link

commented Mar 5, 2019

@christopherhein would it be easier to get this considered if we filed an issue which allows us to specify API server configuration in general, rather than specifically for oidc flags?

These more specific issues really help us to prioritize what is most important. The larger "enable all API flags configurable" are much harder given there is so many controls that could introduce instability if improperly set if everything was customizable. Appreciate you putting this in and sharing the use cases.

@universam1

This comment has been minimized.

Copy link

commented Mar 5, 2019

To second that point of only requesting this very feature for now - while it is rather simple to configure the oidc configuration it is completely indispensable regarding alternatives!
IAM auth can be considered an option for tooling access but application level that is no alternative.
Is there an estimation possible @christopherhein ? Would be helpful for planning

@christopherhein

This comment has been minimized.

Copy link

commented Mar 5, 2019

Estimation for this feature of adding OIDC flag capability @universam1 ? or are you talking about the Pod->IAM configuration #23 ?

@pammi22

This comment has been minimized.

Copy link

commented Mar 6, 2019

@christopherhein is there any Estimation for this feature of adding OIDC flag capability?

@christopherhein

This comment has been minimized.

Copy link

commented Mar 6, 2019

@pammi22 not as of now, we removed the not-planned label in favor of the under consideration while we consider how we would enable this customization with the control plane.

@whereisaaron

This comment has been minimized.

Copy link

commented Mar 17, 2019

The lack of OIDC support for EKS is our single biggest issue for adoption. With stock k8s and dex we have a very clean, two-factor, federated single sign-on for clusters. These flags requested here would enable EKS clusters to have the same great user experience.

If EKS had built-in AWS Cognito support it is possible we could replace dex with Cognito for federating OIDC IDPs. But that support isn’t there currently AFAIK, and I can’t find any existing helper app that might bridge this gap in EKS. Anyone know of a project like this?

@aleks-mariusz

This comment has been minimized.

Copy link

commented Mar 29, 2019

I would like to echo all the sentiments..

We use AD for corporate identity management, and to access AWS console we let the infra/admin group (only) use Okta which loads the console using a dedicated IAM role that grants full access. It is unclear to me how setting up EKS with this assumed IAM role would affect having cluster-admin privs, but wanting to give end-users (sandbox'd) permissions to the kubernetes API server is very messy using EKS.

For contrast, what we currently have on-prem is AD -> federation via Keycloak -> which integrates with the k8s dashboard via the proxy -> k8s dashboard.. and this allows end-users to log in with their AD creds cleanly, which works by mapping via JWT's provided by keycloak (which contain their AD group membership), that membership can then be mapped directly via RBAC rolebindings, to what roles they have (which control what access they have).

It is such a clean and tight integration that it makes us want to consider skipping using EKS altogether and having a cloud-based kubernetes cluster by just managing the control plane ourselves. I have yet to see what using EKS gets you over just rolling your own control plane if we don't have access to provide consistency (auth-wise) with what we have on-prem. :-( Allowing us to add those 4 extra oidc related flags [ oidc-client-id / oidc-issuer-url / oidc-username-claim / oidc-groups-claim ] would have us giving EKS more serious consideration for use.

@Spazzy757

This comment has been minimized.

Copy link

commented Apr 25, 2019

Has there been an update to this issue? We are currently doing a POC for quite a large company to prove that they can move there on-prem clusters to EKS, however, they insist that they would need AD integration. Adding those flags could open up a much larger consumer base for EKS as it would allow migration from systems like AKS where the system is integrated into Azure Active Directory

@philwhln

This comment has been minimized.

Copy link

commented Apr 25, 2019

We had to cancel our PoC of EKS because of this limitation.

@ccojocar

This comment has been minimized.

Copy link

commented Apr 30, 2019

Any ETA for this feature? Thanks

@phanama

This comment has been minimized.

Copy link

commented May 24, 2019

Any updates?
This limitation hesitates us from adopting EKS

@tabern tabern added Proposed and removed Under consideration labels Jun 4, 2019

@tabern tabern added this to We're Working On It in containers-roadmap Jun 5, 2019

@therealsamlin

This comment has been minimized.

Copy link

commented Jun 7, 2019

OIDC is the single reason why we're using kops still instead of EKS. Just saying

@yuriipolishchuk-finsight

This comment has been minimized.

@pvdvreede

This comment has been minimized.

Copy link

commented Jun 7, 2019

@yuriipolishchuk-finsight that seems like an option for the future when its production ready. The only limitation is that because it uses impersonation to work it means that users of the cluster cannot take advantage of impersonation. We use impersonation to elevate our read only privileges to cluster admin so that would be something we would loose with that project.

Nice find though! 👍

@keattang

This comment has been minimized.

Copy link

commented Jul 18, 2019

I created this auth proxy specifically for getting around this issue https://github.com/keattang/eks-auth-proxy/releases/new

@joshkurz

This comment has been minimized.

@jirniy

This comment has been minimized.

Copy link

commented Aug 21, 2019

is oidc options as eks api parameters in roapmap already there have any updates? it's really crucial and must-have option for EKS! we really need that for many of our EKS existing clusters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.