From b910361d54c59b3e072aab1ad7d393e57bf08616 Mon Sep 17 00:00:00 2001 From: Thibault Normand Date: Fri, 8 Nov 2024 14:50:05 +0100 Subject: [PATCH 1/3] chore(dep): run npm audit fix. --- src/graph_notebook/widgets/package.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/graph_notebook/widgets/package.json b/src/graph_notebook/widgets/package.json index 84aa9dbe..0ed0f03e 100644 --- a/src/graph_notebook/widgets/package.json +++ b/src/graph_notebook/widgets/package.json @@ -28,7 +28,7 @@ "@typescript-eslint/eslint-plugin": "2.32.0", "@typescript-eslint/parser": "2.32.0", "chai": "4.2.0", - "css-loader": "3.5.3", + "css-loader": "^7.1.2", "eslint": "6.8.0", "eslint-config-prettier": "6.11.0", "eslint-loader": "4.0.2", @@ -42,9 +42,9 @@ "karma-mocha-reporter": "2.2.5", "karma-sinon": "1.0.5", "karma-sourcemap-loader": "0.3.7", - "karma-webpack": "4.0.2", + "karma-webpack": "^5.0.1", "mkdirp": "0.5.5", - "mocha": "7.1.2", + "mocha": "^10.8.2", "npm-run-all": "4.1.5", "opencollective": "1.0.3", "prettier": "2.0.5", @@ -52,11 +52,11 @@ "sinon": "9.0.2", "source-map-loader": "0.2.4", "style-loader": "1.2.1", - "ts-loader": "5.4.5", + "ts-loader": "^9.5.1", "typescript": "4.1.6", - "webpack": "4.43.0", - "webpack-cli": "3.3.11", - "webpack-dev-server": "3.11.0" + "webpack": "^5.96.1", + "webpack-cli": "^5.1.4", + "webpack-dev-server": "^5.1.0" }, "files": [ "lib/**/*.js", From e267b50df9b0470f0c0dd600d868c52555f925df Mon Sep 17 00:00:00 2001 From: Thibault Normand Date: Fri, 8 Nov 2024 14:51:33 +0100 Subject: [PATCH 2/3] fix(tsc): error in type definition. --- src/graph_notebook/widgets/package.json | 2 +- src/graph_notebook/widgets/src/types.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/graph_notebook/widgets/package.json b/src/graph_notebook/widgets/package.json index 0ed0f03e..015ba1d0 100644 --- a/src/graph_notebook/widgets/package.json +++ b/src/graph_notebook/widgets/package.json @@ -53,7 +53,7 @@ "source-map-loader": "0.2.4", "style-loader": "1.2.1", "ts-loader": "^9.5.1", - "typescript": "4.1.6", + "typescript": "5.6.3", "webpack": "^5.96.1", "webpack-cli": "^5.1.4", "webpack-dev-server": "^5.1.0" diff --git a/src/graph_notebook/widgets/src/types.ts b/src/graph_notebook/widgets/src/types.ts index ad67a25c..e603b3a8 100644 --- a/src/graph_notebook/widgets/src/types.ts +++ b/src/graph_notebook/widgets/src/types.ts @@ -34,7 +34,7 @@ export class VisNode implements Node, DynamicObject { [key: string]: any; - constructor(readonly id: string) { + constructor(id: string) { this.id = id; } @@ -88,9 +88,9 @@ export class VisEdge implements Edge { [key: string]: any; constructor( - readonly from: string, - readonly to: string, - readonly id: string, + from: string, + to: string, + id: string, label: string ) { this.from = from; @@ -184,7 +184,7 @@ export class IdentifiableDynamicObject extends DynamicObject { [key: string]: any; - constructor(readonly id: string) { + constructor(id: string) { super(); this.id = id; } From 6122f8401e820514f80b6069402020d6c6447054 Mon Sep 17 00:00:00 2001 From: Thibault Normand Date: Fri, 8 Nov 2024 15:22:22 +0100 Subject: [PATCH 3/3] chore(dep): rollback npm audit breaking webpack. --- src/graph_notebook/widgets/package.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/graph_notebook/widgets/package.json b/src/graph_notebook/widgets/package.json index 015ba1d0..4dda4e71 100644 --- a/src/graph_notebook/widgets/package.json +++ b/src/graph_notebook/widgets/package.json @@ -28,7 +28,7 @@ "@typescript-eslint/eslint-plugin": "2.32.0", "@typescript-eslint/parser": "2.32.0", "chai": "4.2.0", - "css-loader": "^7.1.2", + "css-loader": "3.5.3", "eslint": "6.8.0", "eslint-config-prettier": "6.11.0", "eslint-loader": "4.0.2", @@ -42,9 +42,9 @@ "karma-mocha-reporter": "2.2.5", "karma-sinon": "1.0.5", "karma-sourcemap-loader": "0.3.7", - "karma-webpack": "^5.0.1", + "karma-webpack": "4.0.2", "mkdirp": "0.5.5", - "mocha": "^10.8.2", + "mocha": "7.1.2", "npm-run-all": "4.1.5", "opencollective": "1.0.3", "prettier": "2.0.5", @@ -52,11 +52,11 @@ "sinon": "9.0.2", "source-map-loader": "0.2.4", "style-loader": "1.2.1", - "ts-loader": "^9.5.1", + "ts-loader": "5.4.5", "typescript": "5.6.3", - "webpack": "^5.96.1", - "webpack-cli": "^5.1.4", - "webpack-dev-server": "^5.1.0" + "webpack": "4.43.0", + "webpack-cli": "3.3.11", + "webpack-dev-server": "3.11.0" }, "files": [ "lib/**/*.js",