From 7cc65a11bb7b43e4ab4d6022c702a0ded3ef610b Mon Sep 17 00:00:00 2001 From: Donald Stufft Date: Thu, 14 Mar 2019 16:10:07 -0400 Subject: [PATCH] Rename BaseKernel/ProcessKernel to Provider to make it more distinct (#385) --- packages/jsii-python-runtime/src/jsii/_kernel/__init__.py | 4 ++-- .../src/jsii/_kernel/providers/__init__.py | 6 +++--- .../jsii-python-runtime/src/jsii/_kernel/providers/base.py | 6 +++--- .../src/jsii/_kernel/providers/process.py | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/jsii-python-runtime/src/jsii/_kernel/__init__.py b/packages/jsii-python-runtime/src/jsii/_kernel/__init__.py index 30386dbe53..a901ed0b71 100644 --- a/packages/jsii-python-runtime/src/jsii/_kernel/__init__.py +++ b/packages/jsii-python-runtime/src/jsii/_kernel/__init__.py @@ -10,7 +10,7 @@ from jsii import _reference_map from jsii._utils import Singleton -from jsii._kernel.providers import BaseKernel, ProcessKernel +from jsii._kernel.providers import BaseProvider, ProcessProvider from jsii._kernel.types import JSClass, Referenceable from jsii._kernel.types import ( EnumRef, @@ -128,7 +128,7 @@ class Kernel(metaclass=Singleton): # them at this layer to translate it to something more Pythonic, depending # on what the provider layer looks like. - def __init__(self, provider_class: Type[BaseKernel] = ProcessKernel) -> None: + def __init__(self, provider_class: Type[BaseProvider] = ProcessProvider) -> None: self.provider = provider_class() # TODO: Do we want to return anything from this method? Is the return value useful diff --git a/packages/jsii-python-runtime/src/jsii/_kernel/providers/__init__.py b/packages/jsii-python-runtime/src/jsii/_kernel/providers/__init__.py index 26ec99a6a2..89dcd54eed 100644 --- a/packages/jsii-python-runtime/src/jsii/_kernel/providers/__init__.py +++ b/packages/jsii-python-runtime/src/jsii/_kernel/providers/__init__.py @@ -1,5 +1,5 @@ -from jsii._kernel.providers.base import BaseKernel -from jsii._kernel.providers.process import ProcessKernel +from jsii._kernel.providers.base import BaseProvider +from jsii._kernel.providers.process import ProcessProvider -__all__ = ["BaseKernel", "ProcessKernel"] +__all__ = ["BaseProvider", "ProcessProvider"] diff --git a/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py b/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py index 27699379b4..92bbdfe27f 100644 --- a/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py +++ b/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py @@ -23,11 +23,11 @@ ) -class BaseKernel(metaclass=abc.ABCMeta): +class BaseProvider(metaclass=abc.ABCMeta): - # The API provided by this Kernel is not very pythonic, however it is done to map + # The API provided by this Provider is not very pythonic, however it is done to map # this API as closely to the JSII runtime as possible. Higher level abstractions - # that layer ontop of the Kernel will provide a translation layer that make this + # that layer ontop of the Provider will provide a translation layer that make this # much more Pythonic. @abc.abstractmethod diff --git a/packages/jsii-python-runtime/src/jsii/_kernel/providers/process.py b/packages/jsii-python-runtime/src/jsii/_kernel/providers/process.py index bc417af56b..b1f0072015 100644 --- a/packages/jsii-python-runtime/src/jsii/_kernel/providers/process.py +++ b/packages/jsii-python-runtime/src/jsii/_kernel/providers/process.py @@ -20,7 +20,7 @@ from jsii.__meta__ import __jsii_runtime_version__ from jsii._compat import importlib_resources from jsii._utils import memoized_property -from jsii._kernel.providers.base import BaseKernel +from jsii._kernel.providers.base import BaseProvider from jsii._kernel.types import ( ObjRef, EnumRef, @@ -302,7 +302,7 @@ def send( raise JSIIError(resp.error) from JavaScriptError(resp.stack) -class ProcessKernel(BaseKernel): +class ProcessProvider(BaseProvider): @memoized_property def _process(self) -> _NodeProcess: process = _NodeProcess()