dotnet: support optional arguments in methods and constructors #210
Labels
effort/small
Small work item – less than a day of effort
language/dotnet
Related to .NET bindings (C#, F#, ...)
p0
Comments
eladb
changed the title
jsii-dotnet-generator should supply default values for arguments with optional types
This was referenced Aug 5, 2019
Closed
RomainMuller
pushed a commit
that referenced
this issue
Aug 9, 2019
Handling optional and variadic parameters in .NET
Emits the =null or params[] keywords when required in constructors or methods.
Ran pack.sh in the CDK with this change, and the S3 construct now looks better:
**Optionals:**
`public Bucket(Amazon.CDK.Construct scope, string id, Amazon.CDK.AWS.S3.IBucketProps props = null): base(new DeputyProps(new object[]{scope, id, props}))
{
}
`
Making the C# call look like:
` var bucket = new Bucket(this, "bucketName");`
Rather than
` var bucket = new Bucket(this, "bucketName", null);`
**Variadic:**
Tested with null values, empty array, one value array, multiple values array.
```
// Array with no value in constructor params
var variadicClassNoParams = new VariadicMethod();
// Array with null value in constructor params
var variadicClassNullParams = new VariadicMethod(null);
// Array with one value in constructor params
var variadicClassOneParam = new VariadicMethod(1);
// Array with multiple values in constructor params
var variadicClassMultipleParams = new VariadicMethod(1, 2, 3, 4);
```
Fixes #153
Fixes #210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jsii methods/constructors can have optional arguments. The .NET generator should respect those and pass
nullin calls that don't supply them.-- from @mpiroc:
jsii-dotnet-generatorshould supply default values for arguments with optional typesjsii-dotnet-generatorensures thatnullis a valid value for types markedoptionalin JSII. For value types, this means making them nullable, i.e.int?. For reference types,nullis already a valid value.When a type like this is used in a parameter list,
jsii-dotnet-generatorshould create a default value ofnullfor the parameter. Currently, the user has to explicitly passnull.The text was updated successfully, but these errors were encountered: