-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting started to use Fargate #1834
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
...tent/en/preview/getting-started/getting-started-with-eksctl/scripts/step02-create-cluster.sh
Outdated
Show resolved
Hide resolved
...preview/getting-started/getting-started-with-eksctl/scripts/step02-create-cluster-fargate.sh
Outdated
Show resolved
Hide resolved
| This guide uses [AWS EKS managed node groups](https://docs.aws.amazon.com/eks/latest/userguide/managed-node-groups.html) to host Karpenter. | ||
| **Example 2: Create basic cluster with Karpenter on Fargate** | ||
|
|
||
| {{% script file="./content/en/{VERSION}/getting-started/getting-started-with-eksctl/scripts/step02-create-cluster-fargate.sh" language="bash"%}} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Fargate we normally need to patch coredns and then restart it (see https://docs.aws.amazon.com/eks/latest/userguide/fargate-getting-started.html#fargate-sg-pod-execution-role). If your fargate profile selects the kube-system namespace, eksctl will do this for you during cluster creation. You'll see logs like:
2022-05-24 21:48:05 [ℹ] "coredns" is now schedulable onto Fargate
2022-05-24 21:50:14 [ℹ] "coredns" is now scheduled onto Fargate
2022-05-24 21:50:15 [ℹ] "coredns" pods are now scheduled onto Fargate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After making the fix you suggested I now see those coredns messages. Should we still add a pointer to the fargate docs on updating CoreDNS or is that something that could perhaps go into the Troubleshooting guide?
...preview/getting-started/getting-started-with-eksctl/scripts/step02-create-cluster-fargate.sh
Show resolved
Hide resolved
...preview/getting-started/getting-started-with-eksctl/scripts/step02-create-cluster-fargate.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested this locally twice.
| @@ -0,0 +1,20 @@ | |||
| eksctl create cluster -f - << EOF | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mu concern with this, is that this is now handled by cloudformation and nobody is going to destroy this, leaving garbage in the user account
1. Issue, if available:
Issue #1812, Issue #1763, Issue #1365,
2. Description of changes:
Update the Karpenter Getting started with eksctl guide with an example that creates a Fargate profile in which to run Karpenter.
I did it the most simple way I could think of. So let me know if I should have gone about it a different way.
3. How was this change tested?
I tested the whole eksctl getting started guide using both cluster creation examples.
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.