Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting started to use Fargate #1834

Merged
merged 3 commits into from
May 26, 2022

Conversation

chrisnegus
Copy link
Member

@chrisnegus chrisnegus commented May 19, 2022

1. Issue, if available:
Issue #1812, Issue #1763, Issue #1365,

2. Description of changes:
Update the Karpenter Getting started with eksctl guide with an example that creates a Fargate profile in which to run Karpenter.

I did it the most simple way I could think of. So let me know if I should have gone about it a different way.

3. How was this change tested?
I tested the whole eksctl getting started guide using both cluster creation examples.

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: see issues above
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chrisnegus chrisnegus requested a review from a team as a code owner May 19, 2022 21:17
@chrisnegus chrisnegus requested a review from dewjam May 19, 2022 21:17
@netlify
Copy link

netlify bot commented May 19, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 218c64c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/628e81158f799a0008517717
😎 Deploy Preview https://deploy-preview-1834--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chrisnegus chrisnegus self-assigned this May 19, 2022
@chrisnegus chrisnegus added the documentation Improvements or additions to documentation label May 19, 2022
@chrisnegus chrisnegus requested a review from suket22 May 20, 2022 12:57
FernandoMiguel
FernandoMiguel previously approved these changes May 20, 2022
This guide uses [AWS EKS managed node groups](https://docs.aws.amazon.com/eks/latest/userguide/managed-node-groups.html) to host Karpenter.
**Example 2: Create basic cluster with Karpenter on Fargate**

{{% script file="./content/en/{VERSION}/getting-started/getting-started-with-eksctl/scripts/step02-create-cluster-fargate.sh" language="bash"%}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Fargate we normally need to patch coredns and then restart it (see https://docs.aws.amazon.com/eks/latest/userguide/fargate-getting-started.html#fargate-sg-pod-execution-role). If your fargate profile selects the kube-system namespace, eksctl will do this for you during cluster creation. You'll see logs like:

2022-05-24 21:48:05 [ℹ]  "coredns" is now schedulable onto Fargate
2022-05-24 21:50:14 [ℹ]  "coredns" is now scheduled onto Fargate
2022-05-24 21:50:15 [ℹ]  "coredns" pods are now scheduled onto Fargate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After making the fix you suggested I now see those coredns messages. Should we still add a pointer to the fargate docs on updating CoreDNS or is that something that could perhaps go into the Troubleshooting guide?

@chrisnegus chrisnegus changed the title [WIP] Update getting started to use Fargate Update getting started to use Fargate May 26, 2022
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested this locally twice.

@chrisnegus chrisnegus merged commit 3116990 into aws:main May 26, 2022
@@ -0,0 +1,20 @@
eksctl create cluster -f - << EOF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mu concern with this, is that this is now handled by cloudformation and nobody is going to destroy this, leaving garbage in the user account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants