Skip to content

Conversation

@wzxxing
Copy link
Contributor

@wzxxing wzxxing commented Nov 17, 2025

…t to 30 seconds to fix integration tests (#60)"

This reverts commit c4c7484.

Summary

Changes

Please provide a summary of what's being changed

Revert the change to increase timeout of integ tests. The timeout was actually an issue because with the transport not being used, the proxy creates session for every requests.

Because we are using stdio which is not aware of the sessionId, the client calls proxy without session ID, and proxy creates a new session.

I think the fastmcp library needs to fix this somehow too, for example, when the proxy is bridging stdio and streamable-http, it does not make sense not to reuse session.

User experience

Please share what the user experience looks like before and after this change

No user experience should be changed.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

  • Yes
  • No

Please add details about how this change was tested.

  • Did integration tests succeed?
  • If the feature is a new use case, is it necessary to add a new integration test case?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…t to 30 seconds to fix integration tests (#60)"

This reverts commit c4c7484.
@wzxxing wzxxing marked this pull request as ready for review November 17, 2025 15:13
@wzxxing wzxxing requested a review from a team as a code owner November 17, 2025 15:13
@wzxxing wzxxing requested review from awsjjzhou and jinet November 17, 2025 15:13
@wzxxing wzxxing enabled auto-merge (squash) November 17, 2025 15:13
@wzxxing wzxxing merged commit 5b99b7e into main Nov 18, 2025
7 checks passed
@wzxxing wzxxing deleted the wzxxing/revert-integ-tests-timeout-fix branch November 18, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants