Add SageMaker-UI poststartup endpoint patch #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description** - Post-startup script stored in SMD (SageMaker Distribution) enables the required customizations for SMUS applications. - This functionality is currently operational for JupyterLab apps. - We are extending this capability to CodeEditor apps. **Testing Done** - Tested building the local image for these changes and tested on personal LL stack using BYOI - Verified script execution logs file generation at /var/log/apps after app launch
aws-asolidu
reviewed
Mar 27, 2025
| * Handles API requests to run the post-startup script in SMD. | ||
| */ | ||
| private async _handlePostStartupScriptInvocation(req: http.IncomingMessage, res: http.ServerResponse): Promise<void> { | ||
| const postStartupScripPath = '/etc/sagemaker-ui/sagemaker_ui_post_startup.sh' |
aws-asolidu
reviewed
Mar 27, 2025
| // Adding 0o755 to make script file executable | ||
| fs.chmodSync(postStartupScripPath, 0o755); | ||
|
|
||
| const subprocess = spawn('bash', [`${postStartupScripPath}`], { cwd: '/' }); |
Contributor
There was a problem hiding this comment.
subprocess errors will not be caught in catch block. see https://stackoverflow.com/questions/48113929/why-does-not-a-try-catch-block-catch-a-child-process-spawn-exception-due-to-inva/48114608
Author
There was a problem hiding this comment.
- This happens only in case of invalid executable path. In our case the script path should always be correct since we are providing it, even if it is incorrect we perform fileExist check which throws 500 error.
- In case of invalid script execution command, the error gets caught and again the server throws 500 error.
- I verified this by running the server locally.
Contributor
There was a problem hiding this comment.
how do we handle errors thrown by the script itself?
Author
There was a problem hiding this comment.
This api just triggers the script execution. If there are errors while executing the script, they get logged in the log file.
aws-asolidu
approved these changes
Mar 28, 2025
austinjang2
pushed a commit
to austinjang2/sagemaker-code-editor
that referenced
this pull request
Sep 11, 2025
Add SageMaker-UI poststartup endpoint patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Done
Issue #, if available:
Description of changes:
Adding
/api/poststartupendpoint for the SageMaker Unified Studio user case that runs the post startup script.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.