Fix: dirs.js and gulpfile.extensions.js patching errors #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const fs = require('fs'); | ||
|
|
||
| // Complete list of directories where yarn should be executed to install node modules | ||
| const dirs = [ |
There was a problem hiding this comment.
Whats with these spacing issues? Ideally we shld have only added a line in this file?
Author
There was a problem hiding this comment.
The spacing is the same. It comes up in the diff for all lines but the removed and added changes are equivalent.
| @@ -1,3879 +1,2 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
Why are we removing this now?
Author
There was a problem hiding this comment.
The lockfile is generated during build itself. Referred to PRs for other extensions as well, the lockfile seems to be empty in all such cases
astitv-sh
force-pushed
the
feature/smus
branch
3 times, most recently
from
7f2020c to
a4ac027
Compare
bharathGuntamadugu
approved these changes
Apr 1, 2025
bharathGuntamadugu
left a comment
bharathGuntamadugu
left a comment
There was a problem hiding this comment.
There seems to be some spacing issues that we can fix if this arise as a problem.
| 'extensions/sagemaker-terminal-crash-mitigation', | ||
| 'extensions/sagemaker-open-notebook-extension', | ||
| 'extensions/sagemaker-ui-dark-theme', | ||
| + 'extensions/post-startup-notifications', |
| 'extensions/sagemaker-terminal-crash-mitigation/tsconfig.json', | ||
| 'extensions/sagemaker-open-notebook-extension/tsconfig.json', | ||
| 'extensions/sagemaker-ui-dark-theme/tsconfig.json', | ||
| + 'extensions/post-startup-notifications/tsconfig.json', |
aws-asolidu
approved these changes
Apr 1, 2025
austinjang2
pushed a commit
to austinjang2/sagemaker-code-editor
that referenced
this pull request
Sep 11, 2025
Fix: dirs.js and gulpfile.extensions.js patching errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixed errors due to patching issues with dirs.js and gulpfile.extensions.js files in post-startup-notifications.patch
Verified changes (Screenshot attached below):
Updates:
Fixed spacing issues with extension files. Added yarn.lock contents to patch and patched-vscode.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.