From e2526cb1672c35d0c6bac12130df68325d3afa5a Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Fri, 1 Aug 2025 15:10:36 -0700 Subject: [PATCH 01/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8bcb260a7..ab0f808e6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -17,10 +17,26 @@ concurrency: cancel-in-progress: ${{ github.event_name == 'pull_request' }} jobs: + # Run unit tests before building the application + run-unit-tests: + name: Run unit tests + runs-on: ubuntu-latest + steps: + # Checkout repository code + - name: Checkout code + uses: actions/checkout@v4 + + # Output placeholder message for unit tests + - name: Hudson's test of unit test + run: echo "Hudson's test of unit test" + + # The main job for building the application build: name: Build sagemaker-code-editor runs-on: ubuntu-latest + # Ensure unit tests pass before building + needs: run-unit-tests timeout-minutes: 180 env: # Environment variable to optimize the build process @@ -128,3 +144,16 @@ jobs: with: name: npm-package path: sagemaker-code-editor-${{ env.VERSION }}.tar.gz + # Run end-to-end tests after the build is complete + run-e2e-tests: + name: Run e2e tests + runs-on: ubuntu-latest + needs: build # Ensure e2e tests run after build + steps: + # Checkout repository code + - name: Checkout code + uses: actions/checkout@v4 + + # Output placeholder message for e2e tests + - name: Hudson's test of e2e test + run: echo "Hudson's test of e2e test" From 0a45c36289dfcb4cb09392afa37c014405ce07be Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Fri, 1 Aug 2025 15:33:48 -0700 Subject: [PATCH 02/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ab0f808e6..36bb109d4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -18,6 +18,7 @@ concurrency: jobs: # Run unit tests before building the application + run-unit-tests: name: Run unit tests runs-on: ubuntu-latest @@ -26,9 +27,19 @@ jobs: - name: Checkout code uses: actions/checkout@v4 - # Output placeholder message for unit tests - - name: Hudson's test of unit test - run: echo "Hudson's test of unit test" + # Verify CSP line exists in target TypeScript file + - name: Check CSP configuration in webClientServer.ts + run: | + TARGET_FILE="sagemaker-code-editor/patched-vscode/src/vs/server/node/webClientServer.ts" + REQUIRED_LINE="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://.gallery.vsassets.io https://.rel.tunnels.api.visualstudio.com wss://.rel.tunnels.api.visualstudio.com https://.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://.vscode-unpkg.net https://open-vsx.org;" + + if grep -F "$REQUIRED_LINE" "$TARGET_FILE" > /dev/null; then + echo "✅ PASS: Required CSP line exists." + else + echo "❌ FAIL: Required CSP line NOT found in $TARGET_FILE" + exit 1 + fi + # The main job for building the application From f4016f1c5bb1d96f190eb48cc948bb3ad2929afe Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 11:55:47 -0700 Subject: [PATCH 03/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 36bb109d4..3a65a0097 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -30,7 +30,7 @@ jobs: # Verify CSP line exists in target TypeScript file - name: Check CSP configuration in webClientServer.ts run: | - TARGET_FILE="sagemaker-code-editor/patched-vscode/src/vs/server/node/webClientServer.ts" + TARGET_FILE="patched-vscode/src/vs/server/node/webClientServer.ts" REQUIRED_LINE="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://.gallery.vsassets.io https://.rel.tunnels.api.visualstudio.com wss://.rel.tunnels.api.visualstudio.com https://.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://.vscode-unpkg.net https://open-vsx.org;" if grep -F "$REQUIRED_LINE" "$TARGET_FILE" > /dev/null; then From 726858b5e86bfad7bdef013ef1c0e7bdc49b60fe Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 12:04:01 -0700 Subject: [PATCH 04/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3a65a0097..7259b3ec9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,12 +31,12 @@ jobs: - name: Check CSP configuration in webClientServer.ts run: | TARGET_FILE="patched-vscode/src/vs/server/node/webClientServer.ts" - REQUIRED_LINE="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://.gallery.vsassets.io https://.rel.tunnels.api.visualstudio.com wss://.rel.tunnels.api.visualstudio.com https://.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://.vscode-unpkg.net https://open-vsx.org;" + REQUIRED_TEXT="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://.gallery.vsassets.io https://.rel.tunnels.api.visualstudio.com wss://.rel.tunnels.api.visualstudio.com https://.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://.vscode-unpkg.net https://open-vsx.org;" - if grep -F "$REQUIRED_LINE" "$TARGET_FILE" > /dev/null; then - echo "✅ PASS: Required CSP line exists." + if grep -F "$REQUIRED_TEXT" "$TARGET_FILE" > /dev/null; then + echo "✅ PASS: Required CSP text exists." else - echo "❌ FAIL: Required CSP line NOT found in $TARGET_FILE" + echo "❌ FAIL: Required CSP text NOT found in $TARGET_FILE" exit 1 fi From b02e2b25fcc932789ef99eec0df60e1afa793d5a Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 12:06:10 -0700 Subject: [PATCH 05/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7259b3ec9..425bf0758 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,8 +31,7 @@ jobs: - name: Check CSP configuration in webClientServer.ts run: | TARGET_FILE="patched-vscode/src/vs/server/node/webClientServer.ts" - REQUIRED_TEXT="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://.gallery.vsassets.io https://.rel.tunnels.api.visualstudio.com wss://.rel.tunnels.api.visualstudio.com https://.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://.vscode-unpkg.net https://open-vsx.org;" - + REQUIRED_TEXT="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://*.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://*.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://*.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://*.gallery.vsassets.io https://*.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com https://*.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://*.vscode-unpkg.net https://open-vsx.org;" if grep -F "$REQUIRED_TEXT" "$TARGET_FILE" > /dev/null; then echo "✅ PASS: Required CSP text exists." else From 247badb549582bfd4eec5f86e4fdef1668da04e2 Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 12:08:11 -0700 Subject: [PATCH 06/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 425bf0758..6604b1514 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -32,6 +32,12 @@ jobs: run: | TARGET_FILE="patched-vscode/src/vs/server/node/webClientServer.ts" REQUIRED_TEXT="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://*.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://*.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://*.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://*.gallery.vsassets.io https://*.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com https://*.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://*.vscode-unpkg.net https://open-vsx.org;" + + if [ ! -f "$TARGET_FILE" ]; then + echo "❌ FAIL: Target file $TARGET_FILE does not exist." + exit 1 + fi + if grep -F "$REQUIRED_TEXT" "$TARGET_FILE" > /dev/null; then echo "✅ PASS: Required CSP text exists." else From 54bb05f6f222e9511a4da8ca5e107b7038185c45 Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 12:10:31 -0700 Subject: [PATCH 07/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6604b1514..78b1c2436 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,7 +31,7 @@ jobs: - name: Check CSP configuration in webClientServer.ts run: | TARGET_FILE="patched-vscode/src/vs/server/node/webClientServer.ts" - REQUIRED_TEXT="connect-src 'self' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://*.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://*.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://*.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://*.gallery.vsassets.io https://*.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com https://*.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://*.vscode-unpkg.net https://open-vsx.org;" + REQUIRED_TEXT='connect-src \'self\' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://*.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://*.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://*.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://*.gallery.vsassets.io https://*.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com https://*.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://*.vscode-unpkg.net https://open-vsx.org;' if [ ! -f "$TARGET_FILE" ]; then echo "❌ FAIL: Target file $TARGET_FILE does not exist." From a1b3af961dcc4d6990a3eb82d8288c915e0b85f8 Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 12:12:44 -0700 Subject: [PATCH 08/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 78b1c2436..c807d005b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,7 +31,7 @@ jobs: - name: Check CSP configuration in webClientServer.ts run: | TARGET_FILE="patched-vscode/src/vs/server/node/webClientServer.ts" - REQUIRED_TEXT='connect-src \'self\' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://*.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://*.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://*.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://*.gallery.vsassets.io https://*.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com https://*.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://*.vscode-unpkg.net https://open-vsx.org;' + REQUIRED_TEXT="'connect-src \'self\' ws: wss: https://main.vscode-cdn.net http://localhost:* https://localhost:* https://login.microsoftonline.com/ https://update.code.visualstudio.com https://*.vscode-unpkg.net/ https://default.exp-tas.com/vscode/ab https://vscode-sync.trafficmanager.net https://vscode-sync-insiders.trafficmanager.net https://*.gallerycdn.vsassets.io https://marketplace.visualstudio.com https://*.blob.core.windows.net https://az764295.vo.msecnd.net https://code.visualstudio.com https://*.gallery.vsassets.io https://*.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com https://*.servicebus.windows.net/ https://vscode.blob.core.windows.net https://vscode.search.windows.net https://vsmarketplacebadges.dev https://vscode.download.prss.microsoft.com https://download.visualstudio.microsoft.com https://*.vscode-unpkg.net https://open-vsx.org;'" if [ ! -f "$TARGET_FILE" ]; then echo "❌ FAIL: Target file $TARGET_FILE does not exist." From dceea6cba649bd37be2386cdae2b7934ef765d98 Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 15:25:18 -0700 Subject: [PATCH 09/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/release.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 32a47dbd6..5d90d0eb6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -32,6 +32,9 @@ jobs: # This is necessary for the release action to create a Git tag in your repository. - name: Checkout code uses: actions/checkout@v4 + with: + ref: ${{ github.event.inputs.source_branch }} + # Step 2: Download the build artifact from your 'Build' workflow. # This finds the latest successful run on the specified branch and downloads the artifact. From eee55fe0c7ad8d58c4a16c9db7d5773fc9e0a398 Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 15:36:41 -0700 Subject: [PATCH 10/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/release.yml | 56 ++++++++++++++++++++++++----------- 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5d90d0eb6..295fc9200 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,7 +11,7 @@ on: type: string # This input allows you to specify which branch to create the release from. source_branch: - description: 'The branch to find the latest successful build artifact on.' + description: 'The branch to find the artifact on and to tag for the release.' required: true type: string # We default to 'main' to make the most common case easy. @@ -28,33 +28,55 @@ jobs: contents: write steps: - # Step 1: Check out the repository code. - # This is necessary for the release action to create a Git tag in your repository. + # Step 1: Check out the repository code FROM THE SPECIFIED SOURCE BRANCH. - name: Checkout code uses: actions/checkout@v4 with: ref: ${{ github.event.inputs.source_branch }} + # Step 2: Explicitly get the commit SHA of the checked-out branch HEAD. + # This ensures we are using the correct commit for tagging. + - name: Get commit SHA + id: get_sha + run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT - # Step 2: Download the build artifact from your 'Build' workflow. - # This finds the latest successful run on the specified branch and downloads the artifact. + # Step 3: Delete existing tag if you want to re-run the release. + - name: Delete existing tag (if any) + uses: actions/github-script@v7 + with: + script: | + const tag = '${{ github.event.inputs.version }}'; + try { + await github.git.deleteRef({ + owner: context.repo.owner, + repo: context.repo.repo, + ref: `tags/${tag}` + }); + console.log(`Deleted existing tag: ${tag}`); + } catch (e) { + console.log(`Tag ${tag} does not exist or already deleted.`); + } + + # Step 4: Download the build artifact from your 'Build' workflow. - name: Download artifact from build workflow uses: dawidd6/action-download-artifact@v6 with: # IMPORTANT: This must match the 'name:' field in your build.yaml file. workflow: build.yml - # Use the branch from the manual input instead of hardcoding 'main'. + # Use the branch from the manual input. branch: ${{ github.event.inputs.source_branch }} + # Tell the action to look for artifacts created by a 'pull_request' event. + event: pull_request + allow_forks: true # We use a wildcard (*) because the artifact name from the build workflow - # contains a dynamic commit SHA (e.g., vscode-reh-web-linux-x64-0.0.0-dev-...). + # contains a dynamic commit SHA. name: npm-package # The path where the downloaded artifact will be saved. path: ./release-assets # Ensure we only get the artifact from a successful run. workflow_conclusion: success - # Step 3: Prepare the release assets by renaming the artifact. - # This takes the downloaded file and gives it a clean, versioned name. + # Step 5: Prepare the release assets by renaming the artifact. - name: Prepare release assets id: prepare_assets run: | @@ -71,8 +93,7 @@ jobs: VERSION_NUM="${VERSION_TAG#v}" # Create the new, clean filename for the release. - # This is the standardized name that your conda-forge recipe will expect. - NEW_FILENAME="sagemaker-code-editor-linux-x64-${VERSION_NUM}.tar.gz" + NEW_FILENAME="code-editor${VERSION_NUM}.tar.gz" # Rename the file. mv "$ARTIFACT_FILE" "./release-assets/$NEW_FILENAME" @@ -81,8 +102,7 @@ jobs: # Set the new filename as an output for the next step. echo "filename=./release-assets/$NEW_FILENAME" >> $GITHUB_OUTPUT - # Step 4: Create the GitHub Release and upload the prepared asset. - # This action creates the tag, the release, and uploads your .tar.gz file. + # Step 6: Create the GitHub Release using the CORRECT commit SHA. - name: Create GitHub Release uses: softprops/action-gh-release@v2 with: @@ -92,8 +112,10 @@ jobs: tag_name: ${{ github.event.inputs.version }} # Path to the file(s) to upload as release assets. files: ${{ steps.prepare_assets.outputs.filename }} - # Set to 'false' to publish immediately, or 'true' to create a draft. + # Set to 'false' to publish immediately. draft: false - # Automatically generate release notes from commits since the last release. - generate_release_notes: true - \ No newline at end of file + # Set to false as we are not using auto-generated notes. + generate_release_notes: false + # CRITICAL: Force the tag to be created on the commit we explicitly got in Step 2. + # This overrides any incorrect metadata from the downloaded artifact. + target_commitish: ${{ steps.get_sha.outputs.sha }} \ No newline at end of file From 4b58391cb2db01d3a91de56e62553af4b9a294ce Mon Sep 17 00:00:00 2001 From: Hudson Xing Date: Mon, 4 Aug 2025 15:41:25 -0700 Subject: [PATCH 11/11] Add unit test and e2e test placeholders to build workflow --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 295fc9200..0d5c98a62 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -66,7 +66,7 @@ jobs: # Use the branch from the manual input. branch: ${{ github.event.inputs.source_branch }} # Tell the action to look for artifacts created by a 'pull_request' event. - event: pull_request + event: push allow_forks: true # We use a wildcard (*) because the artifact name from the build workflow # contains a dynamic commit SHA.