Update build workflow for 1.7 #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakashmandavilli96
approved these changes
Sep 3, 2025
NewtonDer
commented
Sep 3, 2025
| run: | | ||
| TARBALL="vscode-reh-web-linux-x64-${{ env.VERSION }}.tar.gz" | ||
| BUILD_DIR_PATH="${{ steps.find_output.outputs.build_path }}" | ||
| TARBALL="sagemaker-code-editor-${{ env.VERSION }}.tar.gz" |
Author
There was a problem hiding this comment.
@aakashmandavilli96 The filename change here should work fine, since the only place we reference this exact file name is in the next Step 11 for uploading the tarball. In the release workflow, we do a wildcard search for files matching *.tar.gz, which there should only be one (this sagemaker-code-editor-<version>.tar.gz).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update Github build workflow for
1.7to bring it in line with the1.8branch.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.