Skip to content

Accept step object in dependson list #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Aug 3, 2021
Merged

Accept step object in dependson list #2504

merged 37 commits into from
Aug 3, 2021

Conversation

@jerrypeng7773
Copy link
Contributor

@jerrypeng7773 jerrypeng7773 commented Jul 1, 2021 •
edited
Loading

Issue #, if available:

Description of changes:

support step object in step depends on list

Testing done:

unit tested

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jerrypeng7773 and others added 25 commits May 10, 2021 20:18
@jerrypeng7773
add helper function to generate no-op (data ingestion only) recipe
868db55
@jerrypeng7773
Merge branch 'aws:master' into master
21bedbb
@jerrypeng7773
separate flow generation by source input type + move generation helpe…
854dd10 
…rs to sagemaker.wrangler.ingestion
@jerrypeng7773
Merge branch 'aws:master' into master
8798b65
@jerrypeng7773
create an internal helper function to generate output node
69ae4bd
@jerrypeng7773
Merge branch 'master' of github.com:jerrypeng7773/sagemaker-python-sdk
a6a8449
@jerrypeng7773
Merge branch 'aws:master' into master
2aa256e
@jerrypeng7773
add ingestion test using dw processor via pipeline execution
06557a8
@jerrypeng7773
Merge branch 'aws:master' into master
dcbfd13
@jerrypeng7773
verify the fg query df
fc6522e
@ahsan-z-khan
Merge branch 'master' into master
b6f9371
@jerrypeng7773
fix tests
86fa47d
@ahsan-z-khan
Merge branch 'master' into master
05ccfa6
@jerrypeng7773
Merge branch 'aws:master' into master
0716e9f
@jerrypeng7773
add tuning step support
7ca5af4
@jerrypeng7773
fix docstyle check
8cf18b8
@jerrypeng7773
add helper function to get tuning step top performing model s3 uri
1f95b82
@jerrypeng7773
Merge branch 'aws:master' into master
1b9d66b
@jerrypeng7773
allow step depends on pass in step instance
5bc47bd
@jerrypeng7773
Merge branch 'aws:master' into master
603b934
@jerrypeng7773
Merge branch 'master' of github.com:jerrypeng7773/sagemaker-python-sdk
664f2a8
@apogupta2018
Merge branch 'master' into master
a8755ec
@jerrypeng7773
Merge branch 'aws:master' into master
e25d36c
@jerrypeng7773
Merge branch 'master' into accept-step-object-in-dependson-list
a9cfab4
@jerrypeng7773
resolve merge conflict
c0066ea
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: c0066ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jerrypeng7773 jerrypeng7773 marked this pull request as ready for review July 1, 2021 19:05
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Jul 1, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e9ac9fa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

staubhp
staubhp previously approved these changes Jul 1, 2021
View reviewed changes
shreyapandit
shreyapandit previously approved these changes Aug 2, 2021
View reviewed changes
@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 65f9426
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 65f9426
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 65f9426
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 65f9426
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 65f9426
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e3579c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: e3579c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: e3579c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 2, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: e3579c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: e3579c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: cd1f731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: cd1f731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: cd1f731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: cd1f731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: cd1f731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: a4d684a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: a4d684a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: a4d684a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: a4d684a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented Aug 3, 2021

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: a4d684a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahsan-z-khan ahsan-z-khan merged commit 2efaefd into aws:master Aug 3, 2021
@jerrypeng7773 jerrypeng7773 mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@shreyapandit shreyapandit shreyapandit approved these changes

@ahsan-z-khan ahsan-z-khan ahsan-z-khan approved these changes

@staubhp staubhp staubhp left review comments

@EthanShouhanCheng EthanShouhanCheng EthanShouhanCheng left review comments

@navaj0 navaj0 navaj0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jerrypeng7773 @sagemaker-bot @shreyapandit @staubhp @EthanShouhanCheng @navaj0 @ahsan-z-khan @apogupta2018