Skip to content

Fix incorrect default argument for callback output parameter #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Fix incorrect default argument for callback output parameter #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc9a194
Fix incorrect default argument for callback output parameter
Jul 21, 2021
cd018a7
Merge branch 'master' into fix-callback-default-arg
shreyapandit Jul 21, 2021
b8759b3
Merge branch 'master' into fix-callback-default-arg
shreyapandit Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/workflow/callback_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class CallbackOutput:
"""

output_name: str = attr.ib(default=None)
output_type: CallbackOutputTypeEnum = attr.ib(default=CallbackOutputTypeEnum.String.value)
output_type: CallbackOutputTypeEnum = attr.ib(default=CallbackOutputTypeEnum.String)

def to_request(self) -> RequestType:
"""Get the request structure for workflow service calls."""
Expand Down
23 changes: 23 additions & 0 deletions tests/unit/sagemaker/workflow/test_callback_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,29 @@ def test_callback_step():
}


def test_callback_step_default_values():
param = ParameterInteger(name="MyInt")
outputParam1 = CallbackOutput(output_name="output1")
cb_step = CallbackStep(
name="MyCallbackStep",
depends_on=["TestStep"],
sqs_queue_url="https://sqs.us-east-2.amazonaws.com/123456789012/MyQueue",
inputs={"arg1": "foo", "arg2": 5, "arg3": param},
outputs=[outputParam1],
)
cb_step.add_depends_on(["SecondTestStep"])
assert cb_step.to_request() == {
"Name": "MyCallbackStep",
"Type": "Callback",
"DependsOn": ["TestStep", "SecondTestStep"],
"SqsQueueUrl": "https://sqs.us-east-2.amazonaws.com/123456789012/MyQueue",
"OutputParameters": [
{"OutputName": "output1", "OutputType": "String"},
],
"Arguments": {"arg1": "foo", "arg2": 5, "arg3": param},
}


def test_callback_step_output_expr():
param = ParameterInteger(name="MyInt")
outputParam1 = CallbackOutput(output_name="output1", output_type=CallbackOutputTypeEnum.String)
Expand Down