fix: Use correct boto model name for RegisterModelStep properties #2543

staubhp · 2021-07-29T18:40:12Z

Issue #, if available:
N/A

Description of changes:
We are using the incorrect model name for RegisterModelStep properties. DescribeModelPackageResponse -> DescribeModelPackageOutput

Testing done:
Unit, manual

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-07-29T18:53:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 12e81df
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-29T19:15:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 12e81df
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-29T19:19:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 12e81df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-29T19:26:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 12e81df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-29T19:46:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 12e81df
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-29T20:10:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 12e81df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-29T20:44:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 12e81df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

danabens · 2021-07-29T21:11:27Z

failure is unrelated:

= 3 failed, 4794 passed, 445 skipped, 1 xfailed, 1 xpassed, 3046 warnings in 352.71s (0:05:52) =
...
py36: commands succeeded
py37: commands succeeded
ERROR:   py38: parallel child exit code 1</span></span>

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <multiprocess.pool.Pool state=RUN pool_size=2>
    def __reduce__(self):
>       raise NotImplementedError(
              'pool objects cannot be passed between processes or pickled'
              )
E       NotImplementedError: pool objects cannot be passed between processes or pickled
.tox/py38/lib/python3.8/site-packages/multiprocess/pool.py:640: NotImplementedError
______________________ test_ingestion_manager_run_failure ______________________
    @patch(
        "sagemaker.feature_store.feature_group.IngestionManagerPandas._ingest_single_batch",
        MagicMock(return_value=[1]),
    )
    def test_ingestion_manager_run_failure():
       df = pd.DataFrame({"float": pd.Series([2.0], dtype="float64")})
        manager = IngestionManagerPandas(
            feature_group_name="MyGroup",
            sagemaker_fs_runtime_client_config=fs_runtime_client_config_mock,
            max_workers=1,
        )
        with pytest.raises(IngestionError) as error:
>           manager.run(df)

tests/unit/sagemaker/feature_store/test_feature_store.py:336:

shreyapandit

LGTM

sagemaker-bot · 2021-08-01T05:05:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b31051b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T05:32:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b31051b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T05:33:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b31051b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T05:40:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b31051b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T06:53:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b31051b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T08:34:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d813097
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T09:02:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d813097
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T09:05:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d813097
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T09:11:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d813097
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-01T09:17:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d813097
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T16:33:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ad193ae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T16:56:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ad193ae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T16:59:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ad193ae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T17:06:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ad193ae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T17:07:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ad193ae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Use correct boto model name for RegisterModelStep properties

12e81df

nmadan approved these changes Jul 29, 2021

View reviewed changes

danabens approved these changes Jul 29, 2021

View reviewed changes

shreyapandit approved these changes Aug 1, 2021

View reviewed changes

Merge branch 'master' into fix-step-collection-property

b31051b

Merge branch 'master' into fix-step-collection-property

d813097

Merge branch 'master' into fix-step-collection-property

ad193ae

ahsan-z-khan merged commit bd43571 into aws:master Aug 4, 2021

ahsan-z-khan changed the title ~~Use correct boto model name for RegisterModelStep properties~~ fix: Use correct boto model name for RegisterModelStep properties Aug 4, 2021

fix: Use correct boto model name for RegisterModelStep properties #2543

fix: Use correct boto model name for RegisterModelStep properties #2543

Uh oh!

Conversation

staubhp commented Jul 29, 2021

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 29, 2021

AWS CodeBuild CI Report

Uh oh!

danabens commented Jul 29, 2021

Uh oh!

shreyapandit left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 1, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

Uh oh!