fix: Check that serializer and deserializer for predictor is a class (common error). #2753

larroy · 2021-11-04T23:20:59Z

Description of changes:

Added a check so the serializer and deserializers are an instance instead of a class which is a common error which can create confusion and difficult to debug errors when using predictors

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2021-11-04T23:33:08Z

Codecov Report

Merging #2753 (0914f17) into dev (4325fcd) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0914f17 differs from pull request most recent head 06c8263. Consider uploading reports for the commit 06c8263 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2753      +/-   ##
==========================================
- Coverage   89.82%   89.79%   -0.03%     
==========================================
  Files         196      872     +676     
  Lines       16564    77216   +60652     
==========================================
+ Hits        14878    69338   +54460     
- Misses       1686     7878    +6192

Impacted Files	Coverage Δ
src/sagemaker/algorithm.py
src/sagemaker/amazon/amazon_estimator.py
src/sagemaker/amazon/factorization_machines.py
src/sagemaker/amazon/hyperparameter.py
src/sagemaker/amazon/ipinsights.py
src/sagemaker/amazon/kmeans.py
src/sagemaker/amazon/knn.py
src/sagemaker/amazon/lda.py
src/sagemaker/amazon/linear_learner.py
src/sagemaker/amazon/ntm.py
... and 1058 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2021-11-04T23:37:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: efd1ef1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-21T01:30:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e489b61
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-21T02:08:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e489b61
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-14T19:29:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 532e1fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-14T20:21:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 532e1fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-14T20:50:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 532e1fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T19:10:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 317e7e1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T19:51:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 317e7e1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T20:31:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 317e7e1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com>

Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>

trajanikant

/bot run slow-tests

sagemaker-bot · 2022-12-02T21:28:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5e402d1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T21:29:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5e402d1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T21:29:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5e402d1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…aws#3438) Co-authored-by: Keshav Chandak <chakesh@amazon.com>

Co-authored-by: Navin Soni <navinns@amazon.com>

sagemaker-bot · 2022-12-02T22:33:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5e402d1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-02T22:57:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5e402d1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* Add DXB region * Remove change from neuron * Adding DXB to TF 2.1.0 and 2.1.1

…on error).

trajanikant

/bot run all

sagemaker-bot · 2022-12-05T18:54:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b71b7a8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-05T19:02:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b71b7a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-05T19:22:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b71b7a8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-05T19:23:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b71b7a8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-05T20:30:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b71b7a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant · 2023-03-28T00:17:10Z

@larroy Can you resolve the conflicts and get back with some updates on this?
If not we would close this and you can get back with a new PR..

mufaddal-rohawala · 2023-05-09T01:36:57Z

thanks for contributing but this code change has been pending for too long. Please reopen if this change is still relevant!

ahsan-z-khan changed the base branch from master to dev December 21, 2021 01:17

ahsan-z-khan changed the title ~~Check that serializer and deserializer for predictor is a class (common error).~~ fix: Check that serializer and deserializer for predictor is a class (common error). Dec 21, 2021

ahsan-z-khan approved these changes Dec 21, 2021

View reviewed changes

mufaddal-rohawala force-pushed the dev branch from beeabbd to b026769 Compare January 4, 2022 17:09

shreyapandit force-pushed the dev branch from 1c039c8 to 7206b9e Compare January 10, 2022 23:05

shreyapandit added the needs contributor changes label Jan 13, 2022

shreyapandit marked this pull request as draft January 13, 2022 23:27

larroy force-pushed the serde_class branch from e489b61 to 532e1fd Compare January 14, 2022 19:09

shreyapandit force-pushed the dev branch from 903205c to b796a00 Compare January 18, 2022 20:09

BasilBeirouti force-pushed the dev branch from 814dd3d to 70308b1 Compare January 24, 2022 20:10

jeniyat force-pushed the dev branch 3 times, most recently from f5e6849 to 34b07c0 Compare January 29, 2022 23:28

mufaddal-rohawala force-pushed the dev branch 3 times, most recently from 96c01d7 to c437191 Compare February 5, 2022 00:08

jeniyat force-pushed the dev branch from 9d612a7 to bb7563f Compare February 7, 2022 23:40

larroy force-pushed the serde_class branch from 532e1fd to 317e7e1 Compare February 9, 2022 18:52

keerthanvasist approved these changes Feb 21, 2022

View reviewed changes

navinsoni force-pushed the dev branch from 3e68e14 to 668359f Compare February 22, 2022 02:34

shreyapandit and others added 4 commits December 2, 2022 13:18

fix: Allow Py 3.7 for MMS Test Docker env (aws#3080)

41dd330

Co-authored-by: Mufaddal Rohawala <muffi179@gmail.com>

refactoring : using with statement (aws#3286)

1e23a3f

Update local_requirements.txt PyYAML version (aws#3095)

19efadf

Co-authored-by: Basil Beirouti <BasilBeirouti@gmail.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com>

feature: Update TF 2.9 and TF 2.10 inference DLCs (aws#3465)

76f7782

trajanikant reviewed Dec 2, 2022

View reviewed changes

trajanikant force-pushed the serde_class branch from cb0197b to 5e402d1 Compare December 2, 2022 21:27

keshav-chandak and others added 3 commits December 2, 2022 14:11

feature: Added transform with monitoring pipeline step in transformer (…

fde0738

…aws#3438) Co-authored-by: Keshav Chandak <chakesh@amazon.com>

fix: Fix bug forcing uploaded tar to be named sourcedir (aws#3412)

7f9f3b0

feature: Add Code Owners file (aws#3503)

5d59767

Co-authored-by: Navin Soni <navinns@amazon.com>

ci added 2 commits December 3, 2022 03:22

prepare release v2.119.0

0f5cf18

update development version to v2.119.1.dev0

f1f0013

trajanikant force-pushed the serde_class branch from 5e402d1 to 3eb82ad Compare December 5, 2022 17:56

RadhikaB-97 and others added 2 commits December 5, 2022 13:06

feature: Add DXB region to frameworks by DLC (aws#3387)

bb4b689

* Add DXB region * Remove change from neuron * Adding DXB to TF 2.1.0 and 2.1.1

Check that serializer and deserializer for predictor is a class (comm…

b71b7a8

…on error).

trajanikant force-pushed the serde_class branch from 3eb82ad to b71b7a8 Compare December 5, 2022 18:17

trajanikant reviewed Dec 5, 2022

View reviewed changes

mufaddal-rohawala force-pushed the master branch from bae3b8b to d000bdc Compare December 20, 2022 00:31

mufaddal-rohawala closed this May 9, 2023

fix: Check that serializer and deserializer for predictor is a class (common error). #2753

fix: Check that serializer and deserializer for predictor is a class (common error). #2753

Uh oh!

Conversation

larroy commented Nov 4, 2021

Merge Checklist

General

Tests

Uh oh!

codecov-commenter commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Nov 4, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 2, 2022

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2022

AWS CodeBuild CI Report

Uh oh!

trajanikant commented Mar 28, 2023

Uh oh!

mufaddal-rohawala commented May 9, 2023

Uh oh!

codecov-commenter commented Nov 4, 2021 •

edited

Loading