From 99b8c5d6fcfb603d48358deecf675a04ee60bf31 Mon Sep 17 00:00:00 2001 From: Alex Ginglen Date: Mon, 23 Jan 2023 14:18:54 -0600 Subject: [PATCH 1/2] fix(experiments/run.py): added conditional to only append RUN_TC_TAG to tags only if it doesn't exist in the tags in the _append_run_tc_label_to_tags function This change is to stop the RUN_TC_TAG from being duplicated if you run multiple experiments using the same variable for your tags --- src/sagemaker/experiments/run.py | 3 ++- tests/unit/sagemaker/experiments/test_run.py | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/sagemaker/experiments/run.py b/src/sagemaker/experiments/run.py index 1492b6bafa..b34c19bb3a 100644 --- a/src/sagemaker/experiments/run.py +++ b/src/sagemaker/experiments/run.py @@ -648,7 +648,8 @@ def _append_run_tc_label_to_tags(tags: Optional[List[Dict[str, str]]] = None) -> """ if not tags: tags = [] - tags.append(RUN_TC_TAG) + if RUN_TC_TAG not in tags: + tags.append(RUN_TC_TAG) return tags def __enter__(self): diff --git a/tests/unit/sagemaker/experiments/test_run.py b/tests/unit/sagemaker/experiments/test_run.py index 0e4ebee181..b2548a7e1a 100644 --- a/tests/unit/sagemaker/experiments/test_run.py +++ b/tests/unit/sagemaker/experiments/test_run.py @@ -911,6 +911,11 @@ def test_append_run_tc_label_to_tags(): ret = Run._append_run_tc_label_to_tags(tags) assert len(ret) == 2 assert expected_tc_tag in ret + + tags = [expected_tc_tag] + ret = Run._append_run_tc_label_to_tags(tags) + assert len(ret) == 1 + assert expected_tc_tag in ret def _verify_tc_status_before_enter_init(trial_component): From f85af7841f6ddbc481c60d2469b389459bbb3939 Mon Sep 17 00:00:00 2001 From: Alex Ginglen Date: Tue, 31 Jan 2023 12:52:12 -0600 Subject: [PATCH 2/2] refactor(test_run.py): remove white space --- tests/unit/sagemaker/experiments/test_run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/sagemaker/experiments/test_run.py b/tests/unit/sagemaker/experiments/test_run.py index b2548a7e1a..6fc671197e 100644 --- a/tests/unit/sagemaker/experiments/test_run.py +++ b/tests/unit/sagemaker/experiments/test_run.py @@ -911,7 +911,7 @@ def test_append_run_tc_label_to_tags(): ret = Run._append_run_tc_label_to_tags(tags) assert len(ret) == 2 assert expected_tc_tag in ret - + tags = [expected_tc_tag] ret = Run._append_run_tc_label_to_tags(tags) assert len(ret) == 1