Skip to content

Conversation

@papriwal
Copy link
Collaborator

@papriwal papriwal commented Nov 6, 2025

Issue #, if available:

Description of changes:
Fix Python 3.9 tox failure due to google-re2 missing prebuilt wheels. The google-re2 package is transitive dependancy.

  • Latest google-re2 versions lack Python 3.9 wheels
  • Forces source compilation requiring Bazel (not available in CI)
  • Added constraint: google-re2<1.1.20250805; python_version<"3.10"
  • Only affects Python 3.9, allows latest versions on 3.10+

Testing done:

  • Reproduced failure locally with tox -e py39
  • Verified fix resolves build error
  • Confirmed constraint only applies to Python 3.9
  • Tox command completes successfully

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@papriwal papriwal deployed to auto-approve November 6, 2025 22:48 — with GitHub Actions Active
@papriwal papriwal marked this pull request as ready for review November 6, 2025 23:52
@papriwal papriwal requested a review from a team as a code owner November 6, 2025 23:52
@papriwal papriwal merged commit 8e91c2e into aws:master Nov 7, 2025
14 checks passed
@papriwal papriwal deleted the unittestingfix branch November 7, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants