From f3624eb16dc0257d5b6e2fe04942f2b5aeeca836 Mon Sep 17 00:00:00 2001 From: Alex Wood Date: Thu, 13 Oct 2022 15:06:38 -0700 Subject: [PATCH] Add Integ Deployer Logging Improvements We encountered at least one case where StatusReason was not present in a test failure, so making these optional and adding more log detail in case of exceptions. --- integration/helpers/deployer/deployer.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/integration/helpers/deployer/deployer.py b/integration/helpers/deployer/deployer.py index 3dd3d3677..985e385a5 100644 --- a/integration/helpers/deployer/deployer.py +++ b/integration/helpers/deployer/deployer.py @@ -266,9 +266,11 @@ def wait_for_changeset(self, changeset_id, stack_name): waiter.wait(ChangeSetName=changeset_id, StackName=stack_name, WaiterConfig=waiter_config) except botocore.exceptions.WaiterError as ex: + LOG.error("Waiter exception waiting for changeset", exc_info=ex) + resp = ex.last_response - status = resp["Status"] - reason = resp["StatusReason"] + status = resp.get("Status", "") + reason = resp.get("StatusReason", "") if ( status == "FAILED"