New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS MessageBody size validation is incorrect #32

Closed
fredshonorio opened this Issue Jun 20, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@fredshonorio

fredshonorio commented Jun 20, 2018

If I'm reading the code correctly, MessageBody expects a string up to 256 characters in length, this is incorrect according to the documentation, it's 256kb not bytes.

Additionally, the minimum is 1, not 0, and measuring by character length is certain to cause issues when non-ascii characters are in the message.

I could PR a fix if you'd like.

@fredshonorio

This comment has been minimized.

fredshonorio commented Jun 20, 2018

I guess measuring by byte size is not really important because the queue can be configured for smaller sizes anyway (the maximum size is queue dependent).

@amrhassan amrhassan added the bug label Jun 20, 2018

@amrhassan

This comment has been minimized.

Contributor

amrhassan commented Jun 20, 2018

Thank you for reporting. I guess validating against the maximum size wouldn't hurt.

I'll publish a fix in a few minutes..

@amrhassan amrhassan closed this in 3192c64 Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment