New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add s3 directory upload #315

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@toshi0607
Copy link
Contributor

toshi0607 commented Oct 24, 2018

Issue #, if available:

no issue

Description of changes:

added sample of directory upload sample using UploadWithIterator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Doug-AWS

This comment has been minimized.

Copy link
Contributor

Doug-AWS commented Oct 31, 2018

Looks good. I'll add a comment that the object created in the S3 bucket is represented by the fully-qualified path. For example, if I'm on a Windows machine an have \tmp\one.txt, C:\tmp\two.txt and upload \tmp, the resulting objects have those keys.

@Doug-AWS Doug-AWS merged commit c330fc7 into awsdocs:master Oct 31, 2018

@Doug-AWS
Copy link
Contributor

Doug-AWS left a comment

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment