This repository was archived by the owner on Jun 15, 2023. It is now read-only.
docs: add a new subpage for reusing TCP connections in Node.js#20
Merged
Merged
Conversation
wsierakowski
force-pushed
the
docs-keep-alive-node
branch
from
September 18, 2019 09:25
db7fd27 to
3aeea92
Compare
Contributor
|
Thanks Woj. I'll run this by the JS team and let you know how it goes. |
Contributor
|
I'm accepting this and will do some editing once it's merged. |
|
I see merge conflict markers in the merged reusing md file. |
Contributor
|
I'll fix them, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Multiple issues logged in
aws-sdk-jsrepository from users discussing the defaultkeepAlivebehaviour:Description of changes:
I would like to contribute a new page to the "Node.JS considerations" section of the documentation to inform the
aws-sdk-jsusers of the importance of reusing TCP connections to gain substantial performance improvement for their apps using AWS services. I know of many developers, including myself, who had assumed that connections are reused by default and found out about the problem only when the application was struggling to cope with the number of inbound requests and when the high volume of connections was observed at the gateway through which the outbound traffic flows through (in our company setup).I understand that the default behaviour can't be changed for compatibility reasons, therefore I'm proposing to address this issue by making the users aware of this nuance.
I would like to also give credits to the authors of these two resources that helped me better understand and then address this issue:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.