Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

docs: add a new subpage for reusing TCP connections in Node.js#20

Merged
Doug-AWS merged 1 commit into
awsdocs:masterfrom
wsierakowski:docs-keep-alive-node
Sep 24, 2019
Merged

docs: add a new subpage for reusing TCP connections in Node.js#20
Doug-AWS merged 1 commit into
awsdocs:masterfrom
wsierakowski:docs-keep-alive-node

Conversation

@wsierakowski

@wsierakowski wsierakowski commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

Issue #, if available:
Multiple issues logged in aws-sdk-js repository from users discussing the default keepAlive behaviour:

Description of changes:
I would like to contribute a new page to the "Node.JS considerations" section of the documentation to inform the aws-sdk-js users of the importance of reusing TCP connections to gain substantial performance improvement for their apps using AWS services. I know of many developers, including myself, who had assumed that connections are reused by default and found out about the problem only when the application was struggling to cope with the number of inbound requests and when the high volume of connections was observed at the gateway through which the outbound traffic flows through (in our company setup).

I understand that the default behaviour can't be changed for compatibility reasons, therefore I'm proposing to address this issue by making the users aware of this nuance.

I would like to also give credits to the authors of these two resources that helped me better understand and then address this issue:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Doug-AWS

Copy link
Copy Markdown
Contributor

Thanks Woj. I'll run this by the JS team and let you know how it goes.

@Doug-AWS

Copy link
Copy Markdown
Contributor

I'm accepting this and will do some editing once it's merged.

@Doug-AWS
Doug-AWS merged commit af8d2f0 into awsdocs:master Sep 24, 2019
@joebowbeer

Copy link
Copy Markdown

I see merge conflict markers in the merged reusing md file.

@Doug-AWS

Copy link
Copy Markdown
Contributor

I'll fix them, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants