Skip to content

Idle connection culling support #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 2, 2020
Merged

Idle connection culling support #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
77724a9
Idle connection culling support
bretambrose May 21, 2020
a3490fc
assert fixup
bretambrose May 21, 2020
508bd8d
Force the connection manager vtable to be the mock before creation, w…
bretambrose May 21, 2020
d095842
Guarantee cull task doesn't run while releasing connections
bretambrose May 21, 2020
d5f583e
Time is the worst
bretambrose May 21, 2020
1bd414e
Merge branch 'master' into IdleConnectionReaper
bretambrose May 21, 2020
d3ff569
Initialize before using
bretambrose May 21, 2020
08c6002
Merge branch 'IdleConnectionReaper' of github.com:awslabs/aws-c-http …
bretambrose May 21, 2020
6824d92
Documentation:
bretambrose May 21, 2020
201744b
Move from array list to linked lists for culling; use precise time; u…
bretambrose Jun 1, 2020
ae674bb
Self-review part 1
bretambrose Jun 1, 2020
103d710
Doc and format
bretambrose Jun 1, 2020
ea97436
Merge branch 'master' into IdleConnectionReaper
bretambrose Jun 2, 2020
cba44f3
PR Feedback
bretambrose Jun 2, 2020
e846c57
Merge branch 'IdleConnectionReaper' of github.com:awslabs/aws-c-http …
bretambrose Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/aws/http/connection_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ struct aws_http_connection_manager_options {
* If set to true, the read back pressure mechanism will be enabled.
*/
bool enable_read_back_pressure;

/**
* If set to a non-zero value, then connections that stay in the pool longer than the specified
* timeout will be closed automatically.
*/
uint64_t max_connection_idle_in_milliseconds;
};

AWS_EXTERN_C_BEGIN
Expand Down
6 changes: 6 additions & 0 deletions include/aws/http/private/connection_manager_system_vtable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ typedef int(aws_http_connection_manager_create_connection_fn)(const struct aws_h
typedef void(aws_http_connection_manager_close_connection_fn)(struct aws_http_connection *connection);
typedef void(aws_http_connection_manager_release_connection_fn)(struct aws_http_connection *connection);
typedef bool(aws_http_connection_manager_is_connection_open_fn)(const struct aws_http_connection *connection);
typedef bool(aws_http_connection_manager_is_callers_thread_fn)(struct aws_channel *channel);
typedef struct aws_channel *(aws_http_connection_manager_connection_get_channel_fn)(
struct aws_http_connection *connection);

struct aws_http_connection_manager_system_vtable {
/*
Expand All @@ -33,6 +36,9 @@ struct aws_http_connection_manager_system_vtable {
aws_http_connection_manager_close_connection_fn *close_connection;
aws_http_connection_manager_release_connection_fn *release_connection;
aws_http_connection_manager_is_connection_open_fn *is_connection_open;
aws_io_clock_fn *get_monotonic_time;
aws_http_connection_manager_is_callers_thread_fn *is_callers_thread;
aws_http_connection_manager_connection_get_channel_fn *connection_get_channel;
};

AWS_HTTP_API
Expand Down
Loading