Skip to content

check the return code first, in case the connection is null #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2020
Merged

check the return code first, in case the connection is null #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions bin/elasticurl/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,12 +451,6 @@ static void s_on_signing_complete(struct aws_http_message *request, int error_co

static void s_on_client_connection_setup(struct aws_http_connection *connection, int error_code, void *user_data) {
struct elasticurl_ctx *app_ctx = user_data;
if (app_ctx->required_http_version) {
if (aws_http_connection_get_version(connection) != app_ctx->required_http_version) {
fprintf(stderr, "Error. The requested HTTP version, %s, is not supported by the peer.", app_ctx->alpn);
exit(1);
}
}

if (error_code) {
fprintf(stderr, "Connection failed with error %s\n", aws_error_debug_str(error_code));
Expand All @@ -467,6 +461,13 @@ static void s_on_client_connection_setup(struct aws_http_connection *connection,
return;
}

if (app_ctx->required_http_version) {
if (aws_http_connection_get_version(connection) != app_ctx->required_http_version) {
fprintf(stderr, "Error. The requested HTTP version, %s, is not supported by the peer.", app_ctx->alpn);
exit(1);
}
}

app_ctx->connection = connection;
app_ctx->request = s_build_http_request(app_ctx);

Expand Down