RSA PKCS 1.5 SHA1 signing support and der helper functions #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Nov 19, 2024
awscrt/crypto.py
Outdated
| return RSA(binding=_awscrt.rsa_public_key_from_pem_data(pem_data)) | ||
|
|
||
| @staticmethod | ||
| def new_private_key_from_der_data(der_data: Union[str, bytes, bytearray, memoryview]) -> 'RSA': |
Contributor
There was a problem hiding this comment.
I'm confused whether der_data is supposed to be binary or text? I thought DER was binary, but in your tests it looks like BASE64 or something
If it's really only supposed to be binary, then don't take str.
If it is supposed to accept... str, Py_ArgParseTuple("s*") is ALWAYS going to transform it into UTF-8. Is that OK?
graebm
approved these changes
Nov 19, 2024
Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
Co-authored-by: Michael Graeb <graebm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.