New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test code improvement and cleanup #132

Merged

markjschreiber merged 1 commit into awslabs:main from stefanofornari:upstream-main

Aug 1, 2023

Contributor

stefanofornari commented Jul 28, 2023

Issue #, if available:
#131

Description of changes:
Clean up of S3NioSpiConfiguration

addressing issue [US] S3NioSpiConfiguration.withCredentials(null) and withCredentials(null, null) remove credentials #131 (it was already correctly implemented, improved test)
using assertj everywhere

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


          - addressing issue mainstrem awslabs#131; it was already correctly im…

…plemented, improved test

- using assertj everywhere

markjschreiber approved these changes

View reviewed changes

markjschreiber merged commit b854041 into awslabs:main

1 check passed

stefanofornari deleted the upstream-main branch

September 12, 2023 15:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet