Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(feature-flags): correct docs and typing #588

Merged

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Aug 5, 2021

Issue #, if available:

Description of changes:

  • Demark optional value
  • Correct doctstring indents for pdoc3
  • Correct example code type to python

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Demark optional value
- Correct doctstring indents for pdoc3
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #588 (d092123) into develop (92d4a6d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #588   +/-   ##
========================================
  Coverage    99.95%   99.95%           
========================================
  Files          113      113           
  Lines         4533     4533           
  Branches       245      245           
========================================
  Hits          4531     4531           
  Partials         2        2           
Impacted Files Coverage Δ
...da_powertools/utilities/feature_flags/appconfig.py 100.00% <ø> (ø)
..._lambda_powertools/utilities/feature_flags/base.py 100.00% <ø> (ø)
...owertools/utilities/feature_flags/feature_flags.py 100.00% <ø> (ø)
...ambda_powertools/utilities/feature_flags/schema.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d4a6d...d092123. Read the comment docs.

@heitorlessa heitorlessa added the internal Maintenance changes label Aug 5, 2021
@heitorlessa heitorlessa merged commit 4eb4aaa into aws-powertools:develop Aug 5, 2021
@heitorlessa heitorlessa changed the title docs(feature-toggles): correct docs and typing docs(feature-flags): correct docs and typing Aug 10, 2021
@michaelbrewer michaelbrewer deleted the docs/dynamic-feature-toggles-tweaks branch August 15, 2021 19:05
@sthulb sthulb added the feature_flags Feature Flags utility label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_flags Feature Flags utility internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants