Preventing IAM signature requests from blocking the main thread. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
changed the title
|
Thanks for the PR @stefanceriu ! I will have a look at this and reply back. |
rohandubal
approved these changes
Jun 6, 2018
|
Awesome, thank you too. We'll add a small commit to it soon to support cancellations while requesting tokens. |
|
That would be great! Will wait for it 😄 |
rohandubal
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of AWSAppSyncHTTPNetworkTransport's send methods block the main thread waiting for the AWSSignatureV4Signer's credentials provider to fetch access tokens. This is particularly noticeable under poor network conditions.
This PR wraps the URLSessionDataTasks in a Cancellable AWSAppSyncHTTPNetworkTransportOperation and returns early so it doesn't block anymore. The internal dataTask will be populated later as a result of the AWSTask chain.