Only emit terminal codes to terminal (and don't require say)
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for presence of tput and for stdout being a terminal before emitting terminal control codes. Remove unnecessary dependence on `say`
dannysauer
force-pushed
the
bug/no-require-terminal
branch
from
9769e8c
to
65891e2
Compare
|
It would be great to get some eyes on this PR, as we are sporadically hitting the problem of |
dannysauer
changed the title
say)
This was referenced Oct 21, 2022
singholt
added a commit
to singholt/amazon-ecs-agent
that referenced
this pull request
Oct 21, 2022
singholt
added a commit
to singholt/amazon-ecs-agent
that referenced
this pull request
Oct 21, 2022
singholt
added a commit
to singholt/amazon-ecs-agent
that referenced
this pull request
Oct 21, 2022
singholt
added a commit
to singholt/amazon-ecs-agent
that referenced
this pull request
Oct 21, 2022
singholt
added a commit
to aws/amazon-ecs-agent
that referenced
this pull request
Oct 22, 2022
|
Is @mtdowling still affiliated with this project? Your name is all over the blame from seven years ago. :) Trying to find some reviewers. |
mnohe
approved these changes
Jan 16, 2023
sparr
previously approved these changes
Jun 15, 2023
Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
sparr
approved these changes
Jun 20, 2023
This was referenced Jun 20, 2023
creswick
approved these changes
Jun 20, 2023
|
for those who are on MacOS and still encountering this problem, you'll need to use the |
singholt
added a commit
to aws/amazon-ecs-agent
that referenced
this pull request
Oct 11, 2023
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
singholt
added a commit
to aws/amazon-ecs-agent
that referenced
this pull request
Oct 11, 2023
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Oct 23, 2023
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
|
Homebrew's git-secrets v1.3.0 still uses say command, so macOS users encounters VoiceOver's voice from your speaker when you run
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #220
Fixes #239
Description of changes:
say(which was removed: git/git@5b893f7)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.