Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artificial dataset bug #83

Merged
merged 3 commits into from Jun 6, 2019

Conversation

@benidis
Copy link
Contributor

commented Jun 6, 2019

Fix issue #82

The hour and minute random values were out of bound since the random.Random.randint(low, high) gives samples with the limits inclusive (numpy does not).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Konstantinos Benidis
@szha

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@alexw91

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         110      110           
  Lines        6282     6282           
=======================================
  Hits         4940     4940           
  Misses       1342     1342
Impacted Files Coverage Δ
src/gluonts/distribution/binned.py 94.87% <ø> (ø) ⬆️
src/gluonts/dataset/artificial/_base.py 32.16% <0%> (ø) ⬆️
@vafl
vafl approved these changes Jun 6, 2019
@szha

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@szha

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

@benidis benidis merged commit d7e73ec into awslabs:master Jun 6, 2019
4 checks passed
4 checks passed
ci/jenkins/GluonTS-py3-cpu-unittest Job succeeded
Details
ci/jenkins/GluonTS-py3-master-cpu-unittest Job succeeded
Details
ci/jenkins/GluonTS-py3-master-gpu-doc Job succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
lcallot pushed a commit to lcallot/gluon-ts that referenced this pull request Jun 7, 2019
@benidis benidis deleted the benidis:fix_artificial_dataset_bug branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.