Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make usageplan properties referable #1458

Merged
merged 1 commit into from Feb 26, 2020

Conversation

ShreyaGangishetty
Copy link

Issue #, if available:
#1432

Description of changes:
made usageplan resources a referable property to api

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #1458 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1458   +/-   ##
========================================
  Coverage    94.36%   94.36%           
========================================
  Files           78       78           
  Lines         4685     4685           
  Branches       937      937           
========================================
  Hits          4421     4421           
  Misses         121      121           
  Partials       143      143
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 94.06% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fa3b9...78da663. Read the comment docs.

Copy link
Contributor

@praneetap praneetap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs on referable properties

@ShreyaGangishetty
Copy link
Author

Please add docs on referable properties

I will submit another PR for docs on referable properties that will also have other referable properties documented for AWS::Serverless::Function, AWS::Serverless::Api and AWS::Serverless::HttpApi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants