Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe yaml loader #964

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Use safe yaml loader #964

merged 3 commits into from
Oct 21, 2021

Conversation

tdomhan
Copy link
Contributor

@tdomhan tdomhan commented Sep 17, 2021

With this change we make use of the safe yaml loader that only accepts our own defined types and the standard yaml types. Additionally, we make sure to be able load tuples (which are used for buckets and some other parts of the config).

Pull Request Checklist

  • Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
    until you can check this box.
  • Unit tests pass (pytest)
    - [ ] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs?
  • System tests pass (pytest test/system)
  • Passed code style checking (./style-check.sh)
  • You have considered writing a test
  • Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
  • Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tdomhan tdomhan merged commit 35dd717 into master Oct 21, 2021
@tdomhan tdomhan deleted the yaml branch October 21, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants