feat: Added functionality to sync and update the disabled status for a user#9
Merged
Merged
Conversation
jverhoeks
changed the title
katallaxie
reviewed
Jul 28, 2020
Contributor
katallaxie
left a comment
katallaxie
left a comment
There was a problem hiding this comment.
👍 this is really great work. Left some suggestions. Ping me if you feel ready for the next round and then get this merged.
| FindGroupByDisplayName(string) (*Group, error) | ||
| FindUserByEmail(string) (*User, error) | ||
| IsUserInGroup(*User, *Group) (bool, error) | ||
| UpdateUser(*User) (*User, error) |
Contributor
There was a problem hiding this comment.
I would suggest to not use references here, but return the values.
Contributor
Author
There was a problem hiding this comment.
I copied the logic from the other functions. I kept the pointer in the function declaration but changed all functions to return values instead of named return values and referencs
added 7 commits
July 29, 2020 09:59
dancorne
pushed a commit
to fac/ssosync
that referenced
this pull request
Nov 6, 2023
Updating aws-credentials to v2 tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue #8
Description of changes:
This PR add the functionality to synchronise the Active/Disabled State for a user between Gsuite and AWS SSO.
It contains added logic and a new function UpdateUser.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.