-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add method to get the best configuration directly from Tuner, add com… #767
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b10f4a5
Add method to get the best configuration directly from Tuner, add com…
geoalgo b19940e
clean up
geoalgo caab125
black
geoalgo 4472b09
Update syne_tune/util.py
geoalgo c3fc9ca
Merge branch 'main' into checkpoint
geoalgo 853a9ff
fix merge issue
geoalgo d647877
Black
geoalgo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import pytest | ||
|
||
from syne_tune.util import metric_name_mode | ||
|
||
metric_names = ["m1", "m2", "m3"] | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"metric_mode, query_metric, expected_metric, expected_mode,", | ||
[ | ||
("max", "m2", "m2", "max"), | ||
("min", "m2", "m2", "min"), | ||
(["max", "min", "max"], "m2", "m2", "min"), | ||
(["max", "min", "max"], "m3", "m3", "max"), | ||
("max", 1, "m2", "max"), | ||
("min", 1, "m2", "min"), | ||
(["max", "min", "max"], 1, "m2", "min"), | ||
(["max", "min", "max"], 2, "m3", "max"), | ||
], | ||
) | ||
def test_metric_name_mode(metric_mode, query_metric, expected_metric, expected_mode): | ||
metric_name, metric_mode = metric_name_mode( | ||
metric_names=metric_names, metric_mode=metric_mode, metric=query_metric | ||
) | ||
assert metric_name == expected_metric | ||
assert metric_mode == expected_mode |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here or in the FAQ entry, would it make sense to explain when you would use
best_config()
versus a checkpoint?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not really versus, you can only restart from a checkpoint if your script supports checkpointing which may not be the case.
I do not think it would make sense to explain checkpointing there as it has its own set of FAQ items, for instance: