New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several kwalitee fixes #12

Merged
merged 5 commits into from Mar 6, 2017

Conversation

Projects
None yet
2 participants
@kyzn
Contributor

kyzn commented Feb 5, 2017

Hi! Thanks for maintaining this great module.

This PR attempts to improve kwalitee score of Devel::ebug.

has_readme

Seemed like README file was missing in .tar.gz archive. Even though [ReadmeFromPod] was included, I think exclude_match at [GatherDir] was preventing it from being copied properly.

has_meta_json

There was no META.json file, which shouldn't be an issue after using [MetaJSON].

meta_yml_declares_perl_version

There was no minimum perl version listed in meta file, which won't be an issue after including [MinimumPerl]. My dzil build built a META.yml which was saying a minimum of 5.008 was required.

meta_yml_has_provides

Added [MetaProvides::Package] for this one.

[Git::Contributors]

[ContributorsFromGit] was failing a test when I tried to install it, hence I wasn't able to run dzil build successfully at first. Then I found out that it's unmaintained for a long time. See rsrchboy/Dist-Zilla-Plugin-ContributorsFromGit#19 for details.

Updates & comments are appreciated. Have a great weekend!
#cpan-prc

@awwaiid awwaiid merged commit 15ce31f into awwaiid:master Mar 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@awwaiid

This comment has been minimized.

Show comment
Hide comment
@awwaiid

awwaiid Mar 6, 2017

Owner

Thanks!

Owner

awwaiid commented Mar 6, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment