New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't throw warnings if there is -l on the shebang #15

Merged
merged 1 commit into from Mar 12, 2017

Conversation

Projects
None yet
2 participants
@simbabque
Contributor

simbabque commented Mar 12, 2017

There were warnings about undefined variables when the program being debugged had the -l switch in its shebang line. This was due to the fact that -l changes $, which added an additional \n to the serialized data that was written to the socket in the backend. The client then recieved output with two newlines, and had trouble digesting that, resulting in empty data about the basic debugging informaation like the current line (and possibly later other info).

This fixes RT 29956 (https://rt.cpan.org/Public/Bug/Display.html?id=29956) and closes #14.

This is my entry for the Pull Request Challenge 2017.

don't throw warnings if there is -l on the shebang
There were warnings about undefined variables when the program being debugged had the -l switch in its shebang line. This was due to the fact that -l changes $\, which added an additional \n to the serialized data that was written to the socket in the backend. The client then recieved output with two newlines, and had trouble digesting that, resulting in empty data about the basic debugging informaation like the current line (and possibly later other info).

This fixes RT 29956 (https://rt.cpan.org/Public/Bug/Display.html?id=29956) and closes #14.

@awwaiid awwaiid merged commit 0aef611 into awwaiid:master Mar 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simbabque simbabque deleted the simbabque:rt29956 branch Mar 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment