Fixes for #17 to speed up ORDER BY and OFFSET on key and index columns #18

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@pixelcort
Contributor

pixelcort commented Aug 9, 2012

Here are a few changes to speed up SQL queries that use ORDER BY and OFFSET on the key and the index columns.

  1. SQL INDEX are added for the key and inc columns. If the inc column is never sorted by, its index should not be added.
  2. key and index columns have been moved from BLOB to TEXT. This should speed up ORDER BY even more. I'm not familiar with how this will affect collation, if anything, but it's probably no worse than it is already.

These should fix #17.

@axemclion

This comment has been minimized.

Show comment
Hide comment
@axemclion

axemclion Aug 15, 2012

Owner

Thnx for the pull request - will take a look at it over the weekend and merge it. Were all the tests passing ?

Owner

axemclion commented Aug 15, 2012

Thnx for the pull request - will take a look at it over the weekend and merge it. Were all the tests passing ?

@pixelcort

This comment has been minimized.

Show comment
Hide comment
@pixelcort

pixelcort Aug 15, 2012

Contributor

Before this PR the tests were already failing:

  • The number of tests run each time varied: #21
  • Sometimes the tests fail: #12
Contributor

pixelcort commented Aug 15, 2012

Before this PR the tests were already failing:

  • The number of tests run each time varied: #21
  • Sometimes the tests fail: #12
@axemclion

This comment has been minimized.

Show comment
Hide comment
@axemclion

axemclion Nov 26, 2012

Owner

I am looking at re-writing the code, for better error handling, and confirming to the specification. Will add this during that cycle.

Owner

axemclion commented Nov 26, 2012

I am looking at re-writing the code, for better error handling, and confirming to the specification. Will add this during that cycle.

@axemclion axemclion closed this Mar 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment