Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StakingVesting] Too small value for blockProducerBonusPerBlock and bridgeOperatorBonusPerBlock #46

Closed
nxqbao opened this issue Nov 2, 2022 · 0 comments · Fixed by #99
Closed

[StakingVesting] Too small value for blockProducerBonusPerBlock and bridgeOperatorBonusPerBlock #46

nxqbao opened this issue Nov 2, 2022 · 0 comments · Fixed by #99
Labels
clean up

Comments

@nxqbao
Copy link
Collaborator

nxqbao commented Nov 2, 2022

Currently, in many test scripts, the blockProducerBonusPerBlock and bridgeOperatorBonusPerBlock variables of the StakingVesting contract are both set to 1. These values are then multiplied by the percentile of the commission rate, which causes incorrect results in these tests.

Should update the value of both to at least 100 and fix the corresponding test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test] Update small values for *blockRewardAmount in tests axieinfinity/ronin-dpos-contracts
1 participant
@nxqbao